Skip to content

[AutoPR azure-mgmt-monitorslis]-generated-from-SDK Generation - Python-6195144#46478

Merged
saleelpk merged 13 commits into
mainfrom
sdkauto/azure-mgmt-monitorslis-6195144
Apr 27, 2026
Merged

[AutoPR azure-mgmt-monitorslis]-generated-from-SDK Generation - Python-6195144#46478
saleelpk merged 13 commits into
mainfrom
sdkauto/azure-mgmt-monitorslis-6195144

Conversation

@azure-sdk

@azure-sdk azure-sdk commented Apr 22, 2026

Copy link
Copy Markdown
Collaborator

Configurations: 'specification/monitoringservice/resource-manager/Microsoft.Monitor/Slis/tspconfig.yaml', and CommitSHA: 'd32a3f6cc49c6dd6604161f8c7cee7c95a84c578' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6195144 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://web.powerapps.com/apps/821ab569-ae60-420d-8264-d7b5d5ef734c?release-plan-id=2f8fce48-d33d-f111-88b4-000d3a5b007c Submitted by: Saleel.Kattiyat@microsoft.com

Release Plan Details

azure-sdk and others added 4 commits April 22, 2026 23:47
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@saleelpk saleelpk marked this pull request as ready for review April 24, 2026 18:11
Copilot AI review requested due to automatic review settings April 24, 2026 18:11

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds the newly generated azure-mgmt-monitorslis (Monitor SLIs) management SDK package to the sdk/monitor area and wires it into CI for release/validation.

Changes:

  • Register azure-mgmt-monitorslis in sdk/monitor/ci.yml.
  • Add the generated client library (sync + async), models, serialization utilities, and packaging metadata.
  • Add generated samples and generated tests scaffolding.

Reviewed changes

Copilot reviewed 42 out of 42 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
sdk/monitor/ci.yml Adds the new package entry to the monitor CI matrix.
sdk/monitor/azure-mgmt-monitorslis/tsp-location.yaml Captures the spec repo + commit provenance for generation.
sdk/monitor/azure-mgmt-monitorslis/pyproject.toml Defines package metadata, dependencies, and build configuration.
sdk/monitor/azure-mgmt-monitorslis/dev_requirements.txt Adds local dev dependencies for working on the package.
sdk/monitor/azure-mgmt-monitorslis/_metadata.json Records generation inputs (apiVersion, commit, emitterVersion).
sdk/monitor/azure-mgmt-monitorslis/apiview-properties.json Maps public API symbols to cross-language APIView identifiers.
sdk/monitor/azure-mgmt-monitorslis/README.md Adds package README with auth and usage guidance.
sdk/monitor/azure-mgmt-monitorslis/CHANGELOG.md Adds initial changelog entry for 1.0.0b1.
sdk/monitor/azure-mgmt-monitorslis/LICENSE Adds MIT license text for the package.
sdk/monitor/azure-mgmt-monitorslis/MANIFEST.in Specifies files to include in the source distribution.
sdk/monitor/azure-mgmt-monitorslis/azure/init.py Declares the azure namespace package marker.
sdk/monitor/azure-mgmt-monitorslis/azure/mgmt/init.py Declares the azure.mgmt namespace package marker.
sdk/monitor/azure-mgmt-monitorslis/azure/mgmt/monitorslis/init.py Exposes MonitorClient and __version__ for the sync package.
sdk/monitor/azure-mgmt-monitorslis/azure/mgmt/monitorslis/_client.py Implements the synchronous ARM client entrypoint.
sdk/monitor/azure-mgmt-monitorslis/azure/mgmt/monitorslis/_configuration.py Implements sync client configuration and policies.
sdk/monitor/azure-mgmt-monitorslis/azure/mgmt/monitorslis/_patch.py Provides customization hook for generated sync code.
sdk/monitor/azure-mgmt-monitorslis/azure/mgmt/monitorslis/_version.py Defines package version constant.
sdk/monitor/azure-mgmt-monitorslis/azure/mgmt/monitorslis/_utils/init.py Initializes internal utils module.
sdk/monitor/azure-mgmt-monitorslis/azure/mgmt/monitorslis/_utils/model_base.py Adds generated model base and (de)serialization helpers.
sdk/monitor/azure-mgmt-monitorslis/azure/mgmt/monitorslis/_utils/serialization.py Adds generated serializer/deserializer implementation.
sdk/monitor/azure-mgmt-monitorslis/azure/mgmt/monitorslis/models/init.py Exports generated models/enums with patch hook integration.
sdk/monitor/azure-mgmt-monitorslis/azure/mgmt/monitorslis/models/_models.py Adds generated data models for SLI resources.
sdk/monitor/azure-mgmt-monitorslis/azure/mgmt/monitorslis/models/_enums.py Adds generated enums for SLI properties.
sdk/monitor/azure-mgmt-monitorslis/azure/mgmt/monitorslis/models/_patch.py Provides customization hook for generated models.
sdk/monitor/azure-mgmt-monitorslis/azure/mgmt/monitorslis/operations/init.py Exposes operations with patch hook integration.
sdk/monitor/azure-mgmt-monitorslis/azure/mgmt/monitorslis/operations/_operations.py Implements sync SlisOperations REST calls + paging.
sdk/monitor/azure-mgmt-monitorslis/azure/mgmt/monitorslis/operations/_patch.py Provides customization hook for generated operations.
sdk/monitor/azure-mgmt-monitorslis/azure/mgmt/monitorslis/aio/init.py Exposes MonitorClient for async package with patch hook integration.
sdk/monitor/azure-mgmt-monitorslis/azure/mgmt/monitorslis/aio/_client.py Implements the asynchronous ARM client entrypoint.
sdk/monitor/azure-mgmt-monitorslis/azure/mgmt/monitorslis/aio/_configuration.py Implements async client configuration and policies.
sdk/monitor/azure-mgmt-monitorslis/azure/mgmt/monitorslis/aio/_patch.py Provides customization hook for generated async code.
sdk/monitor/azure-mgmt-monitorslis/azure/mgmt/monitorslis/aio/operations/init.py Exposes async operations with patch hook integration.
sdk/monitor/azure-mgmt-monitorslis/azure/mgmt/monitorslis/aio/operations/_operations.py Implements async SlisOperations REST calls + async paging.
sdk/monitor/azure-mgmt-monitorslis/azure/mgmt/monitorslis/aio/operations/_patch.py Provides customization hook for generated async operations.
sdk/monitor/azure-mgmt-monitorslis/azure/mgmt/monitorslis/py.typed Marks the package as typed (PEP 561).
sdk/monitor/azure-mgmt-monitorslis/generated_samples/slis_get.py Adds generated sample for slis.get.
sdk/monitor/azure-mgmt-monitorslis/generated_samples/slis_list_by_parent.py Adds generated sample for slis.list_by_parent.
sdk/monitor/azure-mgmt-monitorslis/generated_samples/slis_delete.py Adds generated sample for slis.delete.
sdk/monitor/azure-mgmt-monitorslis/generated_samples/slis_create_or_update.py Adds generated sample for slis.create_or_update.
sdk/monitor/azure-mgmt-monitorslis/generated_tests/conftest.py Adds pytest fixtures and recording sanitizers for generated tests.
sdk/monitor/azure-mgmt-monitorslis/generated_tests/test_monitor_slis_operations.py Adds generated synchronous tests (currently skipped).
sdk/monitor/azure-mgmt-monitorslis/generated_tests/test_monitor_slis_operations_async.py Adds generated asynchronous tests (currently skipped).
Comments suppressed due to low confidence (7)

sdk/monitor/azure-mgmt-monitorslis/generated_tests/test_monitor_slis_operations.py:1

  • The request body uses the bool type object instead of a boolean value. This will serialize incorrectly if the test is enabled. Replace with a concrete boolean (e.g., True/False) consistent with the scenario being tested.
    sdk/monitor/azure-mgmt-monitorslis/generated_tests/test_monitor_slis_operations_async.py:1
  • The request body uses the bool type object instead of a boolean value. This will serialize incorrectly if the test is enabled. Replace with a concrete boolean (e.g., True/False).
    sdk/monitor/azure-mgmt-monitorslis/generated_tests/test_monitor_slis_operations.py:1
  • These timestamps are formatted with a space separator and no timezone. The generated model fields are datetime (RFC3339) and most ARM endpoints expect RFC3339 (e.g., 2020-02-20T00:00:00Z) if sent as strings. Update the generated test payload to use RFC3339 strings (or actual datetime objects) so the test request is valid when un-skipped.
    sdk/monitor/azure-mgmt-monitorslis/generated_tests/test_monitor_slis_operations_async.py:1
  • These timestamps are formatted with a space separator and no timezone. The corresponding model fields are datetime (RFC3339). Update the generated async test payload to use RFC3339 strings (or actual datetime objects) so the request is valid when un-skipped.
    sdk/monitor/azure-mgmt-monitorslis/generated_tests/conftest.py:1
  • These sanitizers pass environment variable values directly as regex patterns. If any value contains regex metacharacters, the sanitizer can fail or behave unexpectedly. Escape the values (e.g., via re.escape(...)) before using them as regex patterns.
    sdk/monitor/azure-mgmt-monitorslis/dev_requirements.txt:1
  • The generated tests import dotenv (from dotenv import load_dotenv) but python-dotenv is not listed in this package's dev requirements. Add python-dotenv here (or remove the dotenv usage from the generated test config) so local test runs don't fail with ModuleNotFoundError.
    sdk/monitor/azure-mgmt-monitorslis/tsp-location.yaml:1
  • additionalDirectories is declared but has no value, which will parse as null in YAML. If tooling expects a list, prefer additionalDirectories: [] (or omit the key entirely) to avoid downstream parsing/iteration errors.

Comment thread sdk/monitor/azure-mgmt-monitorslis/README.md Outdated
Comment thread sdk/monitor/azure-mgmt-monitorslis/MANIFEST.in
@ChenxiJiang333

Copy link
Copy Markdown
Member

namespace review: https://github.com/Azure/azure-sdk-pr/issues/2567

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 43 out of 43 changed files in this pull request and generated 2 comments.

Comment thread sdk/monitor/azure-mgmt-monitorslis/tsp-location.yaml
Comment thread sdk/monitor/azure-mgmt-monitorslis/pyproject.toml

Copilot AI commented Apr 27, 2026

Copy link
Copy Markdown
Contributor

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • scanning-api.github.com
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

@ChenxiJiang333

Copy link
Copy Markdown
Member

/azp run prepare-pipelines

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@ChenxiJiang333

Copy link
Copy Markdown
Member

Hi @saleelpk, pr ready, feel free to merge and release

@saleelpk saleelpk enabled auto-merge (squash) April 27, 2026 18:43
@saleelpk saleelpk merged commit 4bb8dc9 into main Apr 27, 2026
26 checks passed
@saleelpk saleelpk deleted the sdkauto/azure-mgmt-monitorslis-6195144 branch April 27, 2026 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants