[AutoPR azure-mgmt-monitorslis]-generated-from-SDK Generation - Python-6195144#46478
Conversation
…rosoft.Monitor/Slis/tspconfig.yaml', and CommitSHA: 'd32a3f6cc49c6dd6604161f8c7cee7c95a84c578' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6195144 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds the newly generated azure-mgmt-monitorslis (Monitor SLIs) management SDK package to the sdk/monitor area and wires it into CI for release/validation.
Changes:
- Register
azure-mgmt-monitorslisinsdk/monitor/ci.yml. - Add the generated client library (sync + async), models, serialization utilities, and packaging metadata.
- Add generated samples and generated tests scaffolding.
Reviewed changes
Copilot reviewed 42 out of 42 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/monitor/ci.yml | Adds the new package entry to the monitor CI matrix. |
| sdk/monitor/azure-mgmt-monitorslis/tsp-location.yaml | Captures the spec repo + commit provenance for generation. |
| sdk/monitor/azure-mgmt-monitorslis/pyproject.toml | Defines package metadata, dependencies, and build configuration. |
| sdk/monitor/azure-mgmt-monitorslis/dev_requirements.txt | Adds local dev dependencies for working on the package. |
| sdk/monitor/azure-mgmt-monitorslis/_metadata.json | Records generation inputs (apiVersion, commit, emitterVersion). |
| sdk/monitor/azure-mgmt-monitorslis/apiview-properties.json | Maps public API symbols to cross-language APIView identifiers. |
| sdk/monitor/azure-mgmt-monitorslis/README.md | Adds package README with auth and usage guidance. |
| sdk/monitor/azure-mgmt-monitorslis/CHANGELOG.md | Adds initial changelog entry for 1.0.0b1. |
| sdk/monitor/azure-mgmt-monitorslis/LICENSE | Adds MIT license text for the package. |
| sdk/monitor/azure-mgmt-monitorslis/MANIFEST.in | Specifies files to include in the source distribution. |
| sdk/monitor/azure-mgmt-monitorslis/azure/init.py | Declares the azure namespace package marker. |
| sdk/monitor/azure-mgmt-monitorslis/azure/mgmt/init.py | Declares the azure.mgmt namespace package marker. |
| sdk/monitor/azure-mgmt-monitorslis/azure/mgmt/monitorslis/init.py | Exposes MonitorClient and __version__ for the sync package. |
| sdk/monitor/azure-mgmt-monitorslis/azure/mgmt/monitorslis/_client.py | Implements the synchronous ARM client entrypoint. |
| sdk/monitor/azure-mgmt-monitorslis/azure/mgmt/monitorslis/_configuration.py | Implements sync client configuration and policies. |
| sdk/monitor/azure-mgmt-monitorslis/azure/mgmt/monitorslis/_patch.py | Provides customization hook for generated sync code. |
| sdk/monitor/azure-mgmt-monitorslis/azure/mgmt/monitorslis/_version.py | Defines package version constant. |
| sdk/monitor/azure-mgmt-monitorslis/azure/mgmt/monitorslis/_utils/init.py | Initializes internal utils module. |
| sdk/monitor/azure-mgmt-monitorslis/azure/mgmt/monitorslis/_utils/model_base.py | Adds generated model base and (de)serialization helpers. |
| sdk/monitor/azure-mgmt-monitorslis/azure/mgmt/monitorslis/_utils/serialization.py | Adds generated serializer/deserializer implementation. |
| sdk/monitor/azure-mgmt-monitorslis/azure/mgmt/monitorslis/models/init.py | Exports generated models/enums with patch hook integration. |
| sdk/monitor/azure-mgmt-monitorslis/azure/mgmt/monitorslis/models/_models.py | Adds generated data models for SLI resources. |
| sdk/monitor/azure-mgmt-monitorslis/azure/mgmt/monitorslis/models/_enums.py | Adds generated enums for SLI properties. |
| sdk/monitor/azure-mgmt-monitorslis/azure/mgmt/monitorslis/models/_patch.py | Provides customization hook for generated models. |
| sdk/monitor/azure-mgmt-monitorslis/azure/mgmt/monitorslis/operations/init.py | Exposes operations with patch hook integration. |
| sdk/monitor/azure-mgmt-monitorslis/azure/mgmt/monitorslis/operations/_operations.py | Implements sync SlisOperations REST calls + paging. |
| sdk/monitor/azure-mgmt-monitorslis/azure/mgmt/monitorslis/operations/_patch.py | Provides customization hook for generated operations. |
| sdk/monitor/azure-mgmt-monitorslis/azure/mgmt/monitorslis/aio/init.py | Exposes MonitorClient for async package with patch hook integration. |
| sdk/monitor/azure-mgmt-monitorslis/azure/mgmt/monitorslis/aio/_client.py | Implements the asynchronous ARM client entrypoint. |
| sdk/monitor/azure-mgmt-monitorslis/azure/mgmt/monitorslis/aio/_configuration.py | Implements async client configuration and policies. |
| sdk/monitor/azure-mgmt-monitorslis/azure/mgmt/monitorslis/aio/_patch.py | Provides customization hook for generated async code. |
| sdk/monitor/azure-mgmt-monitorslis/azure/mgmt/monitorslis/aio/operations/init.py | Exposes async operations with patch hook integration. |
| sdk/monitor/azure-mgmt-monitorslis/azure/mgmt/monitorslis/aio/operations/_operations.py | Implements async SlisOperations REST calls + async paging. |
| sdk/monitor/azure-mgmt-monitorslis/azure/mgmt/monitorslis/aio/operations/_patch.py | Provides customization hook for generated async operations. |
| sdk/monitor/azure-mgmt-monitorslis/azure/mgmt/monitorslis/py.typed | Marks the package as typed (PEP 561). |
| sdk/monitor/azure-mgmt-monitorslis/generated_samples/slis_get.py | Adds generated sample for slis.get. |
| sdk/monitor/azure-mgmt-monitorslis/generated_samples/slis_list_by_parent.py | Adds generated sample for slis.list_by_parent. |
| sdk/monitor/azure-mgmt-monitorslis/generated_samples/slis_delete.py | Adds generated sample for slis.delete. |
| sdk/monitor/azure-mgmt-monitorslis/generated_samples/slis_create_or_update.py | Adds generated sample for slis.create_or_update. |
| sdk/monitor/azure-mgmt-monitorslis/generated_tests/conftest.py | Adds pytest fixtures and recording sanitizers for generated tests. |
| sdk/monitor/azure-mgmt-monitorslis/generated_tests/test_monitor_slis_operations.py | Adds generated synchronous tests (currently skipped). |
| sdk/monitor/azure-mgmt-monitorslis/generated_tests/test_monitor_slis_operations_async.py | Adds generated asynchronous tests (currently skipped). |
Comments suppressed due to low confidence (7)
sdk/monitor/azure-mgmt-monitorslis/generated_tests/test_monitor_slis_operations.py:1
- The request body uses the
booltype object instead of a boolean value. This will serialize incorrectly if the test is enabled. Replace with a concrete boolean (e.g.,True/False) consistent with the scenario being tested.
sdk/monitor/azure-mgmt-monitorslis/generated_tests/test_monitor_slis_operations_async.py:1 - The request body uses the
booltype object instead of a boolean value. This will serialize incorrectly if the test is enabled. Replace with a concrete boolean (e.g.,True/False).
sdk/monitor/azure-mgmt-monitorslis/generated_tests/test_monitor_slis_operations.py:1 - These timestamps are formatted with a space separator and no timezone. The generated model fields are datetime (RFC3339) and most ARM endpoints expect RFC3339 (e.g.,
2020-02-20T00:00:00Z) if sent as strings. Update the generated test payload to use RFC3339 strings (or actualdatetimeobjects) so the test request is valid when un-skipped.
sdk/monitor/azure-mgmt-monitorslis/generated_tests/test_monitor_slis_operations_async.py:1 - These timestamps are formatted with a space separator and no timezone. The corresponding model fields are datetime (RFC3339). Update the generated async test payload to use RFC3339 strings (or actual
datetimeobjects) so the request is valid when un-skipped.
sdk/monitor/azure-mgmt-monitorslis/generated_tests/conftest.py:1 - These sanitizers pass environment variable values directly as regex patterns. If any value contains regex metacharacters, the sanitizer can fail or behave unexpectedly. Escape the values (e.g., via
re.escape(...)) before using them as regex patterns.
sdk/monitor/azure-mgmt-monitorslis/dev_requirements.txt:1 - The generated tests import
dotenv(from dotenv import load_dotenv) butpython-dotenvis not listed in this package's dev requirements. Addpython-dotenvhere (or remove the dotenv usage from the generated test config) so local test runs don't fail withModuleNotFoundError.
sdk/monitor/azure-mgmt-monitorslis/tsp-location.yaml:1 additionalDirectoriesis declared but has no value, which will parse asnullin YAML. If tooling expects a list, preferadditionalDirectories: [](or omit the key entirely) to avoid downstream parsing/iteration errors.
|
namespace review: https://github.com/Azure/azure-sdk-pr/issues/2567 |
…rosoft.Monitor/Slis/tspconfig.yaml', and CommitSHA: '1346e6b895a9091a6adbeec3505ee47f55d3ecee' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6212027 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
Agent-Logs-Url: https://github.com/Azure/azure-sdk-for-python/sessions/934e2d65-3148-482d-ad65-aa1910922cee Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
…rosoft.Monitor/Slis/tspconfig.yaml', and CommitSHA: 'fa74a24ebfcd57429a95ef827b06eae0e639800a' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6212690 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
|
/azp run prepare-pipelines |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hi @saleelpk, pr ready, feel free to merge and release |
Configurations: 'specification/monitoringservice/resource-manager/Microsoft.Monitor/Slis/tspconfig.yaml', and CommitSHA: 'd32a3f6cc49c6dd6604161f8c7cee7c95a84c578' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6195144 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://web.powerapps.com/apps/821ab569-ae60-420d-8264-d7b5d5ef734c?release-plan-id=2f8fce48-d33d-f111-88b4-000d3a5b007c Submitted by: Saleel.Kattiyat@microsoft.com
Release Plan Details
Spec pull request: Exclude SloView operations from SDK generation azure-rest-api-specs#42529
Spec API version: 2025-03-01-preview