Lazy-init toolbox MCP connections on first request#46525
Merged
Conversation
Move toolbox MCP connect_toolboxes() from initialize() (startup) to _get_or_create_session() (first request) to fix race condition where tool discovery fails because platform-injected user context is not yet available at startup time. Uses double-checked locking with asyncio.Lock to prevent concurrent initialization from parallel requests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
tendau
requested review from
code-vicar,
ganeshyb,
jodeklotzms and
pradeepkintali
as code owners
pradeepkintali
approved these changes
Apr 24, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Defers MCP toolbox connections from startup initialization to the first request/session creation to avoid missing platform-injected user context, using an asyncio.Lock to avoid concurrent initialization.
Changes:
- Added lazy toolbox initialization (
_ensure_toolboxes) guarded by double-checked locking. - Removed toolbox connection from
initialize()and invoked it from_get_or_create_session(). - Added state/lock fields to track one-time toolbox initialization.
fafhrd91
pushed a commit
to fafhrd91/azure-sdk-for-python
that referenced
this pull request
Apr 28, 2026
Move toolbox MCP connect_toolboxes() from initialize() (startup) to _get_or_create_session() (first request) to fix race condition where tool discovery fails because platform-injected user context is not yet available at startup time. Uses double-checked locking with asyncio.Lock to prevent concurrent initialization from parallel requests. Co-authored-by: root <root@CPC-cearl-W9ZSG.localdomain> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move toolbox MCP connect_toolboxes() from initialize() (startup) to _get_or_create_session() (first request) to fix race condition where tool discovery fails because platform-injected user context is not yet available at startup time.
Uses double-checked locking with asyncio.Lock to prevent concurrent initialization from parallel requests.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new API spec, a link to the pull request containing these API spec changes should be included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines