[Storage] Simplify Encoder seek, fix SM streaming retry#46564
Merged
jalauzon-msft merged 4 commits intoAzure:feature/storage/content-validation-102from Apr 28, 2026
Merged
Conversation
jalauzon-msft
requested review from
annatisch,
vincenttran-msft and
weirongw23-msft
as code owners
weirongw23-msft
approved these changes
Apr 28, 2026
jalauzon-msft
merged commit 6ae8592
into
Azure:feature/storage/content-validation-102
26 checks passed
jalauzon-msft
added a commit
that referenced
this pull request
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change simplifies the
StructuredMessageEncodeStream.seekmethod to only support seeking to position zero withSEEK_SET. This also simplifiedreada bit as we no longer need to track the checksum offset, checksums will just be re-computed. This was done because this stream is not exposed to users andseekis only used internally for retry where it will always useSEEK_SETto0. The previous logic, while correct, while quite complex and difficult to maintain.Additionally, this adds a test for and fixes an issue with crc64 streaming retry in async by making the
closemethod a no-op. Theclosemethod is automatically called byaiohttpso retries would break.