Skip to content

Remove Ruff support#46578

Merged
JennyPng merged 5 commits intoAzure:mainfrom
JennyPng:remove-ruff
Apr 30, 2026
Merged

Remove Ruff support#46578
JennyPng merged 5 commits intoAzure:mainfrom
JennyPng:remove-ruff

Conversation

@JennyPng
Copy link
Copy Markdown
Member

@JennyPng JennyPng commented Apr 28, 2026

We are deciding not to keep Ruff as a quality check since we're currently not fully investing in it

(eng/tox files aren't used anymore, will fully delete in a separate PR)

@JennyPng JennyPng marked this pull request as ready for review April 28, 2026 19:28
Copilot AI review requested due to automatic review settings April 28, 2026 19:28
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes Ruff linting support from the repo’s Python tooling and documentation, aligning CI and local tooling with the decision to stop running Ruff checks.

Changes:

  • Removed Ruff configuration blocks from agentserver package pyproject.toml files.
  • Removed Ruff execution paths from tooling/CI (tox env, azpysdk command, weekly analyze pipeline).
  • Updated docs to eliminate Ruff references and reproduction steps.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.

Show a summary per file
File Description
sdk/agentserver/azure-ai-agentserver-responses/pyproject.toml Removes [tool.ruff] config for this package.
sdk/agentserver/azure-ai-agentserver-invocations/pyproject.toml Removes [tool.ruff] config and isort-related ruff lint settings.
sdk/agentserver/azure-ai-agentserver-githubcopilot/pyproject.toml Removes [tool.ruff] config for this package.
sdk/agentserver/azure-ai-agentserver-core/pyproject.toml Removes [tool.ruff] config for this package.
eng/tox/tox.ini Removes the testenv:ruff tox environment.
eng/tox/run_ruff.py Deletes the tox helper script used to run Ruff.
eng/tools/azure-sdk-tools/azpysdk/ruff.py Deletes the azpysdk ruff check implementation.
eng/tools/azure-sdk-tools/azpysdk/main.py Removes ruff import/registration from the azpysdk CLI.
eng/pipelines/templates/stages/python-analyze-weekly.yml Removes the weekly “Run Ruff” pipeline step.
doc/tool_usage_guide.md Removes azpysdk ruff from the documented tool list.
doc/eng_sys_checks.md Removes the Ruff section and TOC entry under weekly analyze checks.
CONTRIBUTING.md Updates weekly analyze checks description to drop Ruff mention.

Comment thread doc/eng_sys_checks.md
Comment thread eng/tox/tox.ini
Copy link
Copy Markdown
Member

@scbedd scbedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments!

Copy link
Copy Markdown
Member

@lmazuel lmazuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving without reading as "Yes, let's remove ruff". Please reach technical comments from @scbedd and @l0lawrence before merging.

@JennyPng JennyPng requested a review from scbedd April 30, 2026 20:26
@JennyPng JennyPng merged commit d0f2455 into Azure:main Apr 30, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants