Skip to content
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ We maintain an [additional document](https://github.com/Azure/azure-sdk-for-pyth
- [Install and test checks](https://github.com/Azure/azure-sdk-for-python/blob/main/doc/eng_sys_checks.md#install-and-test-checks) (whl, sdist, mindependency, latestdependency, devtest, regression)
- [PR validation](https://github.com/Azure/azure-sdk-for-python/blob/main/doc/eng_sys_checks.md#pr-validation) (subset that runs on every pull request)
- [Nightly and release checks](https://github.com/Azure/azure-sdk-for-python/blob/main/doc/eng_sys_checks.md#nightly-and-release) (full check set including latestdependency, whl_no_aio, import_all)
- [Weekly analyze checks](https://github.com/Azure/azure-sdk-for-python/blob/main/doc/eng_sys_checks.md#weekly-analyze-checks) (ruff, next-generation tool versions)
- [Weekly analyze checks](https://github.com/Azure/azure-sdk-for-python/blob/main/doc/eng_sys_checks.md#weekly-analyze-checks) (next-generation tool versions)
- [pyproject.toml configuration](https://github.com/Azure/azure-sdk-for-python/blob/main/doc/eng_sys_checks.md#the-pyprojecttoml) (enabling/disabling checks per package, analyze_python_version override)
- [Skipping checks at queue time](https://github.com/Azure/azure-sdk-for-python/blob/main/doc/eng_sys_checks.md#skipping-checks-at-queue-time)

Expand Down
13 changes: 0 additions & 13 deletions doc/eng_sys_checks.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@
- [Regression Test](#regression-test)
Comment thread
JennyPng marked this conversation as resolved.
- [Autorest Automation](#autorest-automation)
- [Weekly Analyze Checks](#weekly-analyze-checks)
- [Ruff](#ruff)
- [Next-Generation Checks](#next-generation-checks)

This document describes every CI check run against Azure SDK for Python packages — what each one does, when it runs, and how to reproduce it locally.
Expand Down Expand Up @@ -590,18 +589,6 @@ python scripts/devops_tasks/verify_autorest.py --service_directory <your_service

The following checks run on a weekly cadence (not on every PR or nightly) via the `python-analyze-weekly` pipeline. They are exploratory/informational and use `continueOnError: true`, meaning failures are surfaced as warnings but do not block merges.

### Ruff

<a name="ruff"></a>

[`Ruff`](https://docs.astral.sh/ruff/) is a fast Python linter and formatter written in Rust. It runs only during the weekly analyze job, not on every PR.

To run locally:

```bash
azpysdk ruff .
```

### Next-Generation Checks

<a name="next-generation-checks"></a>
Expand Down
1 change: 0 additions & 1 deletion doc/tool_usage_guide.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ The following checks are available via the `azpysdk` entrypoint.
|`pyright`| Runs `pyright` checks or `next-pyright` checks. (based on presence of `--next` argument) | `azpysdk pyright .` |
|`black`| Runs `black` checks. | `azpysdk black .` |
|`verifytypes`| Runs `verifytypes` checks. | `azpysdk verifytypes .` |
|`ruff`| Runs `ruff` checks. | `azpysdk ruff .` |
|`apistub`| Generates an api stub for the package. | `azpysdk apistub .` |
|`bandit`| Runs `bandit` checks, which detect common security issues. | `azpysdk bandit .` |
|`verifywhl`| Verifies that the root directory in whl is azure, and verifies manifest so that all directories in source are included in sdist. | `azpysdk verifywhl .` |
Expand Down
13 changes: 0 additions & 13 deletions eng/pipelines/templates/stages/python-analyze-weekly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -72,19 +72,6 @@ stages:
env:
GH_TOKEN: $(azuresdk-github-pat)

- task: PythonScript@0
displayName: 'Run Ruff'
continueOnError: true
inputs:
scriptPath: 'eng/scripts/dispatch_checks.py'
arguments: >-
${{ parameters.BuildTargetingString }}
--service="${{ parameters.ServiceDirectory }}"
--checks="ruff"
--disablecov
env:
GH_TOKEN: $(azuresdk-github-pat)

- script: |
python -m pip install PyGithub>=1.59.0
python -m pip install requests>=2.0
Expand Down
2 changes: 0 additions & 2 deletions eng/tools/azure-sdk-tools/azpysdk/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
from .black import black
from .pyright import pyright
from .next_pyright import next_pyright
from .ruff import ruff
from .verifytypes import verifytypes
from .apistub import apistub
from .verify_sdist import verify_sdist
Expand Down Expand Up @@ -138,7 +137,6 @@ def build_parser() -> argparse.ArgumentParser:
black().register(subparsers, [common])
pyright().register(subparsers, [common])
next_pyright().register(subparsers, [common])
ruff().register(subparsers, [common])
verifytypes().register(subparsers, [common])
apistub().register(subparsers, [common])
verify_sdist().register(subparsers, [common])
Expand Down
74 changes: 0 additions & 74 deletions eng/tools/azure-sdk-tools/azpysdk/ruff.py

This file was deleted.

42 changes: 0 additions & 42 deletions eng/tox/run_ruff.py

This file was deleted.

19 changes: 0 additions & 19 deletions eng/tox/tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -144,25 +144,6 @@ commands =
--package-type sdist
python {repository_root}/eng/tox/run_pylint.py -t {tox_root} --next=True

[testenv:ruff]
Comment thread
scbedd marked this conversation as resolved.
description=Lints a package with ruff
skipsdist = true
skip_install = true
usedevelop = false
setenv =
{[testenv]setenv}
PROXY_URL=http://localhost:5022
deps =
{[base]deps}
ruff
commands =
python {repository_root}/eng/tox/create_package_and_install.py \
-d {envtmpdir}/dist \
-p {tox_root} \
-w {envtmpdir} \
--package-type sdist
python {repository_root}/eng/tox/run_ruff.py -t {tox_root}

[testenv:mypy]
description=Typechecks a package with mypy (version {[testenv:mypy]mypy_version})
mypy_version=1.19.1
Expand Down
11 changes: 0 additions & 11 deletions sdk/agentserver/azure-ai-agentserver-core/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -53,17 +53,6 @@ readme = { file = ["README.md"], content-type = "text/markdown" }
[tool.setuptools.package-data]
"azure.ai.agentserver.core" = ["py.typed"]

[tool.ruff]
line-length = 120
target-version = "py310"
lint.select = ["E", "F", "B", "I"]
lint.ignore = []
fix = false

[tool.ruff.lint.isort]
known-first-party = ["azure.ai.agentserver.core"]
combine-as-imports = true

[tool.azure-sdk-build]
breaking = false
mypy = true
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,17 +42,6 @@ readme = { file = ["README.md"], content-type = "text/markdown" }
[tool.setuptools.package-data]
pytyped = ["py.typed"]

[tool.ruff]
line-length = 120
target-version = "py311"
lint.select = ["E", "F", "B", "I"]
lint.ignore = []
fix = false

[tool.ruff.lint.isort]
known-first-party = ["azure.ai.agentserver.githubcopilot"]
combine-as-imports = true

[tool.azure-sdk-build]
analyze_python_version = "3.11"
breaking = false
Expand Down
11 changes: 0 additions & 11 deletions sdk/agentserver/azure-ai-agentserver-invocations/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -62,17 +62,6 @@ readme = { file = ["README.md"], content-type = "text/markdown" }
[tool.setuptools.package-data]
"azure.ai.agentserver.invocations" = ["py.typed"]

[tool.ruff]
line-length = 120
target-version = "py310"
lint.select = ["E", "F", "B", "I"]
lint.ignore = []
fix = false

[tool.ruff.lint.isort]
known-first-party = ["azure.ai.agentserver.invocations"]
combine-as-imports = true

[tool.azure-sdk-build]
analyze_python_version = "3.11"
breaking = false
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,14 +50,6 @@ exclude = [
[tool.setuptools.package-data]
pytyped = ["py.typed"]

[tool.ruff]
target-version = "py310"
line-length = 120
exclude = ["azure/ai/agentserver/responses/models/_generated"]

[tool.ruff.lint]
select = ["E", "F", "W", "I"]

[tool.mypy]
python_version = "3.10"
warn_return_any = true
Expand Down
Loading