Skip to content

Sync eng/common directory with azure-sdk-tools for PR 15357#46606

Open
azure-sdk wants to merge 6 commits intomainfrom
sync-eng/common-prepare-pipelines-transition-15357
Open

Sync eng/common directory with azure-sdk-tools for PR 15357#46606
azure-sdk wants to merge 6 commits intomainfrom
sync-eng/common-prepare-pipelines-transition-15357

Conversation

@azure-sdk
Copy link
Copy Markdown
Collaborator

Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#15357 See eng/common workflow

Copilot AI review requested due to automatic review settings April 29, 2026 18:54
@azure-sdk azure-sdk requested a review from a team as a code owner April 29, 2026 18:54
@azure-sdk azure-sdk requested a review from scbedd April 29, 2026 18:54
@azure-sdk azure-sdk added EngSys This issue is impacting the engineering system. Central-EngSys This issue is owned by the Engineering System team. labels Apr 29, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Syncs eng/common pipeline templates with the corresponding updates from azure-sdk-tools PR 15357, primarily around GitHub authentication/token handling in pipeline jobs.

Changes:

  • Added login-to-github.yml usage to mint GitHub App installation tokens in pipeline jobs.
  • Switched GitHub auth inputs from $(azuresdk-github-pat) to $(GH_TOKEN) / $(GH_TOKEN_Azure) in the updated flows.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
eng/common/pipelines/templates/jobs/prepare-pipelines.yml Adds GitHub login step for *-pr repos and updates sparse-checkout auth to use $(GH_TOKEN).
eng/common/pipelines/templates/archetype-typespec-emitter.yml Adds GitHub login steps to regeneration jobs and updates PR submission auth token usage.

APIReview_AutoCreate_Configurations: 93

steps:
- ${{ if endsWith(parameters.Repository, '-pr') }}:
Copy link

Copilot AI Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

login-to-github.yml runs before sparse-checkout.yml, but login-to-github.yml executes eng/common/scripts/login-to-github.ps1 via scriptPath. In this job, the only checkout currently comes from sparse-checkout.yml (which also does checkout: none by default), so the repo files containing eng/common/scripts/ are not guaranteed to exist yet when the login step runs. This is likely to fail with a missing script path. Consider either (a) ensuring the repo containing eng/common/scripts/login-to-github.ps1 is checked out before this step, or (b) restructuring so the login step can run after a checkout that includes /eng/common/scripts (and adjusting how the auth token is provided to the subsequent sparse checkout).

Suggested change
- ${{ if endsWith(parameters.Repository, '-pr') }}:
- ${{ if endsWith(parameters.Repository, '-pr') }}:
- checkout: self

Copilot uses AI. Check for mistakes.
@azure-sdk azure-sdk force-pushed the sync-eng/common-prepare-pipelines-transition-15357 branch 2 times, most recently from 5e9bae8 to ab909cc Compare May 6, 2026 16:57
@azure-sdk azure-sdk force-pushed the sync-eng/common-prepare-pipelines-transition-15357 branch from ab909cc to f2556db Compare May 6, 2026 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants