[Storage Files] Migrating to TypeSpec#46929
Draft
l0lawrence wants to merge 60 commits into
Draft
Conversation
l0lawrence
commented
May 15, 2026
| if parallel and "modified_access_conditions" in kwargs: | ||
| # Access conditions do not work with parallelism | ||
| kwargs["modified_access_conditions"] = None | ||
| if parallel: |
Member
Author
There was a problem hiding this comment.
these changes are from storage-blob changes with typespec
l0lawrence
commented
May 15, 2026
| @@ -53,18 +54,20 @@ class ShareLeaseClient: # pylint: disable=client-accepts-api-version-keyword | |||
| This will be `None` if no lease has yet been acquired or modified.""" | |||
|
|
|||
| def __init__( # pylint: disable=missing-client-constructor-parameter-credential, missing-client-constructor-parameter-kwargs | |||
| self, client: Union["ShareFileClient", "ShareClient"], | |||
| lease_id: Optional[str] = None | |||
l0lawrence
commented
May 15, 2026
| if isinstance(self._client, FileOperations) and lease_break_period: | ||
| raise TypeError("Setting a lease break period is only applicable to Share leases.") | ||
|
|
||
| if self._allow_trailing_dot is not None: |
Member
Author
There was a problem hiding this comment.
why does this have a if not none check
l0lawrence
commented
May 15, 2026
Member
Author
|
/azp run python - storage - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run python - storage - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run python - storage - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run python - storage - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run python - storage - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
need to ensure content-validation is working as expected