Skip to content

match foundry project endpoint host by suffix not substring #47412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alhudz wants to merge 3 commits into
base: main
Choose a base branch
from
Open

match foundry project endpoint host by suffix not substring #47412

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a104dd7
match foundry project endpoint host by suffix not substring
alhudz Jun 9, 2026
e7eecbd
require non-empty resource label before host suffix
alhudz Jun 11, 2026
d1fcce6
bump ghcopilot package version to 1.0.0b3 for changelog entry
alhudz Jun 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions sdk/agentserver/azure-ai-agentserver-ghcopilot/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Release History

## 1.0.0b3 (Unreleased)

### Bugs Fixed

- `_derive_resource_url_from_project_endpoint` now matches the project endpoint host by suffix instead of substring, so a look-alike host (e.g. `<name>.services.ai.azure.com.example`) no longer derives an attacker-controlled resource URL.

## 1.0.0b2 (2026-04-24)

### Breaking Changes
Expand Down
5 changes: 3 additions & 2 deletions ...ver/azure-ai-agentserver-ghcopilot/azure/ai/agentserver/githubcopilot/_copilot_adapter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,8 +128,9 @@ def _derive_resource_url_from_project_endpoint(project_endpoint: str) -> str:
(".services.ai.azure.cn", ".cognitiveservices.azure.cn"),
(".services.ai.azure.us", ".cognitiveservices.azure.us"),
]:
if project_pat in hostname:
return f"https://{hostname.replace(project_pat, resource_pat)}"
if hostname.endswith(project_pat):
resource_host = hostname[: -len(project_pat)] + resource_pat
return f"https://{resource_host}"

@alhudz alhudz Jun 11, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point. Added a length guard so the host needs a non-empty label before the suffix, and a test that https://.services.ai.azure.com/... now raises ValueError instead of deriving https://.cognitiveservices.azure.com. Kept it as endswith plus length check rather than a regex since the supported cloud list already lives in the suffix table.


raise ValueError(f"Cannot derive RESOURCE_URL from: {project_endpoint}")

Expand Down
7 changes: 7 additions & 0 deletions sdk/agentserver/azure-ai-agentserver-ghcopilot/tests/unit_tests/test_replat_features.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,13 @@ def test_derive_resource_url_invalid(self):
with pytest.raises(ValueError, match="Cannot derive"):
_derive_resource_url_from_project_endpoint("https://unknown.example.com/foo")

def test_derive_resource_url_rejects_lookalike_host(self):
"""A look-alike host that only contains the suffix is rejected."""
with pytest.raises(ValueError, match="Cannot derive"):
_derive_resource_url_from_project_endpoint(
"https://victim.services.ai.azure.com.attacker.example/api/projects/myproject"
)

def test_get_project_endpoint_new_var(self):
"""Prefers FOUNDRY_PROJECT_ENDPOINT over legacy name."""
with patch.dict(os.environ, {
Expand Down
Loading