[EngSys] Lint workflows with actionlint#47467
Merged
Merged
Conversation
mikeharder
changed the title
actionlint
mikeharder
changed the title
actionlintactionlint
mikeharder
commented
Jun 12, 2026
mikeharder
commented
Jun 12, 2026
Co-authored-by: Mike Harder <mharder@microsoft.com>
mikeharder
requested review from
a team,
ChenxiJiang333,
iscai-msft,
msyyc and
tadelesh
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces GitHub Actions workflow linting via actionlint, while also modernizing and hardening several existing workflow scripts (quoting/safer shell patterns) and updating common actions to newer major versions.
Changes:
- Add an
Actionlintworkflow plus a problem matcher and repo config for self-hosted runner label validation. - Harden shell scripting in the TypeSpec regenerate workflow (safer
$GITHUB_OUTPUTwrites and saferrm -rfusage). - Update workflow dependencies (e.g.,
actions/checkout,actions/setup-python) and improve quoting in run steps.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/typespec-python-regenerate.yml | Hardens shell scripting for output writing and guarded deletion in regen flow. |
| .github/workflows/dependency-checker.yml | Bumps actions/checkout and actions/setup-python major versions. |
| .github/workflows/copilot-setup-steps.yml | Updates setup-python and quotes writes to $GITHUB_ENV / $GITHUB_PATH. |
| .github/workflows/azure-sdk-tools.yml | Updates action versions and improves quoting for install paths/extras. |
| .github/workflows/actionlint.yml | Adds new workflow to run actionlint with matcher integration. |
| .github/matchers/actionlint.json | Adds problem matcher for actionlint output. |
| .github/actionlint.yaml | Adds actionlint config for self-hosted runner labels. |
tjprescott
approved these changes
Jun 12, 2026
mikeharder
requested review from
benbp,
danieljurek,
scbedd and
weshaggard
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.