Fix pylint 4.0.4 in the distro#47532
Merged
Merged
Conversation
4e1cd79 to
04bc745
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the azure-monitor-opentelemetry package to address new/updated pylint findings (notably around exception logging and line-length) and refreshes the package’s API documentation artifacts.
Changes:
- Adjusted tests to remove unused mocks/imports, add targeted pylint suppressions, and reformat long connection strings.
- Added/expanded pylint suppressions related to exception logging (including module-level disables in the browser SDK loader).
- Added generated API surface files (
api.md,api.metadata.yml).
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 14 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/monitor/azure-monitor-opentelemetry/tests/browserSdkLoader/test_snippet_injector.py | Removes unused mock imports and reformats long connection string constants. |
| sdk/monitor/azure-monitor-opentelemetry/tests/browserSdkLoader/test_integration.py | Reformats long connection strings and adds pylint suppressions in one test. |
| sdk/monitor/azure-monitor-opentelemetry/tests/browserSdkLoader/test_django_middleware.py | Removes unused mock imports, reformats long connection string, and simplifies a conditional branch. |
| sdk/monitor/azure-monitor-opentelemetry/tests/browserSdkLoader/test_config.py | Removes unused mock imports and reformats a long connection string constant. |
| sdk/monitor/azure-monitor-opentelemetry/samples/logging/modify_logs.py | Adds a pylint suppression for a long line in a sample. |
| sdk/monitor/azure-monitor-opentelemetry/azure/monitor/opentelemetry/_diagnostics/diagnostic_logging.py | Adds a pylint suppression around exception logging (with some redundancy). |
| sdk/monitor/azure-monitor-opentelemetry/azure/monitor/opentelemetry/_browser_sdk_loader/snippet_injector.py | Adds module-level and inline pylint suppressions for exception logging warnings. |
| sdk/monitor/azure-monitor-opentelemetry/azure/monitor/opentelemetry/_browser_sdk_loader/django_middleware.py | Adds a module-level pylint suppression for exception logging. |
| sdk/monitor/azure-monitor-opentelemetry/azure/monitor/opentelemetry/_browser_sdk_loader/init.py | Adds a pylint suppression on a warning log with exc_info=True. |
| sdk/monitor/azure-monitor-opentelemetry/api.metadata.yml | Adds generated API metadata for the package. |
| sdk/monitor/azure-monitor-opentelemetry/api.md | Adds generated API markdown for the package surface. |
JacksonWeber
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.