Skip to content

[Storage] Fixed live tests relating to File Share #47558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
weirongw23-msft merged 3 commits into from
Jun 18, 2026
Merged

[Storage] Fixed live tests relating to File Share #47558

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c53b1df
Fixed list share lease test
weirongw23-msft Jun 18, 2026
21d373f
Typo
weirongw23-msft Jun 18, 2026
66a0f2e
Async test was failing, matched sync test by removing sorting
weirongw23-msft Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions sdk/storage/azure-storage-file-share/tests/test_share.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -814,11 +814,11 @@ def test_list_shares_leased_share(self, **kwargs):

# Act
lease = share.acquire_lease(lease_id="00000000-1111-2222-3333-444444444444")
resp = list(self.fsc.list_shares())
resp = [s for s in list(self.fsc.list_shares()) if s.name == share.share_name]

# Assert
assert resp is not None
assert len(resp) >= 1
assert len(resp) == 1
assert resp[0] is not None
assert resp[0].lease.duration == "infinite"
assert resp[0].lease.status == "locked"
Expand Down Expand Up @@ -935,8 +935,6 @@ def test_list_shares_with_num_results_and_marker(self, **kwargs):
for i in range(0, 4):
share_names.append(self._create_share(prefix + str(i)).share_name)

# share_names.sort()

# Act
generator1 = self.fsc.list_shares(prefix, results_per_page=2).by_page()
shares1 = list(next(generator1))
Expand Down
7 changes: 3 additions & 4 deletions sdk/storage/azure-storage-file-share/tests/test_share_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -816,11 +816,12 @@ async def test_list_shares_leased_share(self, **kwargs):
lease = await share.acquire_lease(lease_id="00000000-1111-2222-3333-444444444444")
resp = []
async for s in self.fsc.list_shares():
resp.append(s)
if s.name == share.share_name:
resp.append(s)

# Assert
assert resp is not None
assert len(resp) >= 1
assert len(resp) == 1
assert resp[0] is not None
assert resp[0].lease.duration == "infinite"
assert resp[0].lease.status == "locked"
Expand Down Expand Up @@ -944,8 +945,6 @@ async def test_list_shares_with_num_results_and_marker(self, **kwargs):
share = await self._create_share(prefix + str(i))
share_names.append(share.share_name)

share_names.sort()

# Act
generator1 = self.fsc.list_shares(prefix, results_per_page=2).by_page()
shares1 = []
Expand Down
Loading