Merge remote-tracking branch 'origin/main' into simorenoh/cosmos-ga-readiness-review

Author: simorenoh

.github/CODEOWNERS

@@ -74,14 +74,14 @@
 # AzureSDKOwners: @vincenttran-msft @jalauzon-msft @jaschrep-msft
 
 # PRLabel: %Event Hubs
-/sdk/eventhubs/          @j7nw4r
+/sdk/eventhubs/          @j7nw4r @SwayGom @sagar0207
 
 # PRLabel: %Event Hubs %Storage
-/sdk/eventhubs/azure_messaging_eventhubs_checkpointstore_blob/    @j7nw4r @jalauzon-msft @vincenttran-msft @jaschrep-msft
+/sdk/eventhubs/azure_messaging_eventhubs_checkpointstore_blob/    @j7nw4r @SwayGom @sagar0207 @jalauzon-msft @vincenttran-msft @jaschrep-msft
 
 # ServiceLabel: %Event Hubs
 # AzureSDKOwners: @LarryOsterman
-# ServiceOwners: @j7nw4r
+# ServiceOwners: @j7nw4r @SwayGom @sagar0207
 
 ####################
 # Management Libraries
@@ -90,11 +90,11 @@
 ###########
 # Eng Sys
 ###########
-/eng/                    @danieljurek @weshaggard @heaths @xirzec @RickWinter
+/eng/                    @danieljurek @heaths @xirzec @RickWinter
 /eng/common/             @Azure/azure-sdk-eng
 /.github/workflows/      @Azure/azure-sdk-eng
 /.github/CODEOWNERS      @xirzec @RickWinter @Azure/azure-sdk-eng
-/.config/1espt/          @benbp @weshaggard
+/.config/1espt/          @benbp
 /sdk/canary/             @danieljurek
 
 # Add owners for notifications for specific pipelines

.github/prompts/perf-test.prompt.md .github/skills/create-perf-test/SKILL.md.github/prompts/perf-test.prompt.md renamed to .github/skills/create-perf-test/SKILL.md

@@ -1,13 +1,14 @@
 ---
-agent: "agent"
-description: "Generate a new performance test"
+name: create-perf-test
+description: Generate a new performance test
+disable-model-invocation: true
 ---
 
 # Generate a new performance test
 
 You will generate a new performance (perf) test under the `sdk/{service-directory}/{crate-name}/perf` directory as `${input:testName:perf_test_name}.rs` where:
 
-- `{service-directory}` is the directory name under [sdk](../../sdk) for the current ${file} e.g., `core`.
+- `{service-directory}` is the directory name under [sdk](../../../sdk) for the current ${file} e.g., `core`.
 - `{crate-name}` is the crate directory name under `sdk/{service-directory}` for the current ${file} e.g., `azure_core`.
 
 ## Set up
@@ -24,9 +25,9 @@ These instructions only need to be done once. If changes described are already p
   ```
 
 - Under the `{crate-name}` directory, add a `perf/perf_tests.rs` file that uses `azure_core_test::perf::PerfRunner` to register and run the crate's perf tests.
-- Under the `{crate-name}` directory, copy [sdk/core/perf.yml](../../sdk/core/perf.yml) and change _only_ the following contents:
+- Under the `{crate-name}` directory, copy [sdk/core/perf.yml](../../../sdk/core/perf.yml) and change _only_ the following contents:
   - Change `ServiceDirectory` to match the `{service-directory}`.
-- Under the `{crate-name}` directory, copy [sdk/core/perf-tests.yml](../../sdk/core/perf-tests.yml) and change _only_ the following contents:
+- Under the `{crate-name}` directory, copy [sdk/core/perf-tests.yml](../../../sdk/core/perf-tests.yml) and change _only_ the following contents:
   - Change `Service` to match the `{service-directory}`.
   - Change `Project` to match the `{crate-name}`.
   - Change the `PackageVersions` to replace `azure_core` with the `{crate-name}`.
@@ -38,7 +39,7 @@ For each new perf test:
 - In `sdk/{service-directory}/{crate-name}/perf/${input:testName}.rs`:
   - Add a type that implements `azure_core_test::perf::PerfTest`.
   - Generate a perf test for the currently selected function in ${file} or specified client method name, if any.
-  - Use [sdk/keyvault/azure_security_keyvault_keys/perf/get_key.rs](../../sdk/keyvault/azure_security_keyvault_keys/perf/get_key.rs) or [sdk/storage/azure_storage_blob/perf/list_blob_test.rs](../../sdk/storage/azure_storage_blob/perf/list_blob_test.rs) as examples.
+  - Use [sdk/keyvault/azure_security_keyvault_keys/perf/get_key.rs](../../../sdk/keyvault/azure_security_keyvault_keys/perf/get_key.rs) or [sdk/storage/azure_storage_blob/perf/list_blob_test.rs](../../../sdk/storage/azure_storage_blob/perf/list_blob_test.rs) as examples.
   - Define a `test_metadata()` function returning `PerfTestMetadata`, including any required command-line options.
   - Separate setup, the measured operation, and cleanup in the `PerfTest` implementation.
   - If credentials are needed, prefer the crate's existing perf-test pattern (for example `context.recording().credential()` or an existing helper) instead of introducing a new authentication flow.

.github/prompts/recorded-test.prompt.md …hub/skills/create-recorded-test/SKILL.md.github/prompts/recorded-test.prompt.md renamed to .github/skills/create-recorded-test/SKILL.md .github/prompts/recorded-test.prompt.md renamed to .github/skills/create-recorded-test/SKILL.md

@@ -1,14 +1,15 @@
 ---
-agent: "agent"
-description: "Generate a new recorded integration test"
+name: create-recorded-test
+description: Generate a new recorded integration test
+disable-model-invocation: true
 ---
 
 # Generate a new recorded integration test
 
 You will generate one or more recorded integration tests under the `sdk/{service-directory}/{crate-name}/tests` directory in `${input:testFile:test_file}.rs` where:
 
 - `{repo-root}` is the root directory containing `Cargo.toml`.
-- `{service-directory}` is the directory name under [sdk](../../sdk) for the current ${file} e.g., `keyvault`.
+- `{service-directory}` is the directory name under [sdk](../../../sdk) for the current ${file} e.g., `keyvault`.
 - `{crate-name}` is the crate directory name under `sdk/{service-directory}` for the current ${file} e.g., `azure_security_keyvault_secrets`.
 
 ## Set up
@@ -24,7 +25,7 @@ These instructions only need to be done once. If changes described are already p
   ```
 
 - To run recorded tests, rely on the existing test infrastructure. Test Proxy is acquired automatically for test runs when needed, but not for `test-proxy push -a sdk/{service-directory}/assets.json`.
-- For manual Test Proxy usage or asset publishing, see [CONTRIBUTING.md](../../CONTRIBUTING.md) and the [Test Proxy documentation](https://github.com/Azure/azure-sdk-tools/blob/main/tools/test-proxy/Azure.Sdk.Tools.TestProxy/README.md).
+- For manual Test Proxy usage or asset publishing, see [CONTRIBUTING.md](../../../CONTRIBUTING.md) and the [Test Proxy documentation](https://github.com/Azure/azure-sdk-tools/blob/main/tools/test-proxy/Azure.Sdk.Tools.TestProxy/README.md).
 
 ## Adding a new recorded test
 
@@ -37,7 +38,7 @@ For each new recorded test:
   - `let mut options = {Client}Options::default();`
   - `recording.instrument(&mut options.client_options);`
 - Construct clients with `recording.var("{ENV_VAR}", None).as_str()`, `recording.credential()`, and `Some(options)`.
-- Use [sdk/keyvault/azure_security_keyvault_secrets/tests/secret_client.rs](../../sdk/keyvault/azure_security_keyvault_secrets/tests/secret_client.rs) as the example for function signatures, `TestContext`, and required `ClientOptions` instrumentation.
+- Use [sdk/keyvault/azure_security_keyvault_secrets/tests/secret_client.rs](../../../sdk/keyvault/azure_security_keyvault_secrets/tests/secret_client.rs) as the example for function signatures, `TestContext`, and required `ClientOptions` instrumentation.
 - Generate one test per client method or scenario the user wants to cover. If multiple methods share setup and belong together, keep them in the same integration test file as separate `#[recorded::test]` functions.
 - Prefer asserting on returned models or observable state instead of only checking success.
 - Reuse existing crate patterns for imports, helper types, resource naming, and environment variables.

.github/workflows/verify-links.yml

@@ -0,0 +1,71 @@
+name: Verify Links
+
+on:
+  pull_request:
+    branches:
+      - main
+      - release/*
+      - hotfix/*
+  check_run:
+    types:
+      - completed
+  workflow_dispatch:
+
+permissions:
+  contents: read
+
+jobs:
+  verify-links:
+    name: Verify Links
+    if: >-
+      github.event_name == 'pull_request' ||
+      (
+        github.event_name == 'check_run' &&
+        github.event.check_run.check_suite.app.name == 'Azure Pipelines' &&
+        (
+          (github.repository == 'Azure/azure-sdk-for-net' && contains(github.event.check_run.name, 'Compliance')) ||
+          (github.repository == 'Azure/azure-sdk-for-python' && contains(github.event.check_run.name, 'Analyze')) ||
+          (github.repository == 'Azure/azure-sdk-for-java' && contains(github.event.check_run.name, 'Analyze')) ||
+          (github.repository == 'Azure/azure-sdk-for-js' && contains(github.event.check_run.name, 'Analyze')) ||
+          (github.repository == 'Azure/azure-sdk-for-c' && contains(github.event.check_run.name, 'GenerateReleaseArtifacts')) ||
+          (github.repository == 'Azure/azure-sdk-for-cpp' && contains(github.event.check_run.name, 'GenerateReleaseArtifacts')) ||
+          (github.repository == 'Azure/azure-sdk-for-go' && contains(github.event.check_run.name, 'Analyze')) ||
+          (github.repository == 'Azure/azure-sdk-for-ios' && contains(github.event.check_run.name, 'Analyze'))
+        )
+      )
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+        with:
+          ref: ${{ github.event.pull_request.head.sha || github.event.check_run.head_sha || github.sha }}
+          fetch-depth: 0
+
+      - name: Link verification check
+        shell: pwsh
+        env:
+          SYSTEM_PULLREQUEST_TARGETBRANCH: ${{ github.base_ref }}
+          SYSTEM_PULLREQUEST_SOURCECOMMITID: ${{ github.event.pull_request.head.sha }}
+        run: |
+          $urls = & ./eng/common/scripts/get-markdown-files-from-changed-files.ps1
+          if (-not $urls -or $urls.Count -eq 0) {
+            Write-Host "No changed markdown files; nothing to verify."
+            exit 0
+          }
+
+          $sourceRepoUri  = '${{ github.event.pull_request.head.repo.html_url }}'
+          $defaultBranch  = '${{ github.event.repository.default_branch }}'
+          $branchReplaceRegex = "^($sourceRepoUri(?:\.git)?/(?:blob|tree)/)$defaultBranch(/.*)$"
+
+          ./eng/common/scripts/Verify-Links.ps1 `
+            -urls $urls `
+            -rootUrl "file://$env:GITHUB_WORKSPACE/" `
+            -recursive:$false `
+            -ignoreLinksFile "$env:GITHUB_WORKSPACE/eng/ignore-links.txt" `
+            -branchReplaceRegex $branchReplaceRegex `
+            -branchReplacementName '${{ github.event.pull_request.head.sha }}' `
+            -checkLinkGuidance:$true `
+            -localBuildRepoName '${{ github.repository }}' `
+            -localBuildRepoPath $env:GITHUB_WORKSPACE `
+            -inputCacheFile "https://azuresdkartifacts.blob.core.windows.net/verify-links-cache/verify-links-cache.txt" `
+            -allowRelativeLinksFile "$env:GITHUB_WORKSPACE/eng/common/scripts/allow-relative-links.txt"

.vscode/settings.json

@@ -1,5 +1,6 @@
 {
   "azure-pipelines.1ESPipelineTemplatesSchemaFile": true,
+  "cmake.ignoreCMakeListsMissing": true,
   "cSpell.enabled": true,
   "editor.formatOnSave": true,
   "files.associations": {
@@ -17,9 +18,16 @@
   ],
   "rust-analyzer.cargo.features": "all",
   "rust-analyzer.check.command": "clippy",
+  "rust-analyzer.linkedProjects": [
+    "Cargo.toml",
+    "eng/tools/Cargo.toml",
+    "eng/scripts/update-cratenames.rs",
+    "eng/scripts/update-pathversions.rs",
+    "eng/scripts/verify-dependencies.rs",
+    "eng/scripts/verify-keywords.rs",
+  ],
   "yaml.format.printWidth": 240,
   "[powershell]": {
     "editor.defaultFormatter": "ms-vscode.powershell",
   },
-  "cmake.ignoreCMakeListsMissing": true,
 }

AGENTS.md

@@ -24,7 +24,6 @@ The Azure SDK for Rust provides Rust language bindings and client libraries for
 ├── doc/                      # Additional documentation
 ├── .github/
 │   ├── instructions/         # Agent instruction files for specific tasks
-│   ├── prompts/              # Reusable Copilot prompts
 │   └── skills/               # Copilot skills (e.g., check-spelling, lint-markdown)
 ├── CONTRIBUTING.md           # Contribution guidelines (see for detailed workflows)
 └── README.md                 # Repository overview
@@ -265,10 +264,11 @@ Integration tests use the Azure SDK Test Proxy for recording/playback. See `CONT
 Additional specialized instructions for specific workflows can be found in:
 
 - [.github/instructions](.github/instructions) - Task-specific instructions (loaded when pattern-matched)
-- [.github/prompts](.github/prompts) - Reusable Copilot prompts (use `/{prompt-name}` in Copilot)
 - [.github/skills](.github/skills) - Copilot skills for common tasks (use `/{skill-name}` in Copilot):
   - `check-spelling` - Check and fix spelling in project source files using cSpell
   - `create-crate` - Create a new Azure SDK crate from a TypeSpec specification
+  - `create-perf-test` - Generate a new performance test
+  - `create-recorded-test` - Generate a new recorded integration test
   - `lint-markdown` - Check and fix formatting in markdown files using markdownlint-cli2
 
 ## Cross-References

CONTRIBUTING.md

@@ -21,12 +21,12 @@ Further discussion on or pull requests for these issues is highly valued, and we
 ## Using Copilot
 
 This repository is [configured](https://code.visualstudio.com/docs/copilot/copilot-customization) to facilitate Copilot.
-In addition to [general instructions](https://github.com/Azure/azure-sdk-for-rust/blob/main/AGENTS.md), you can find additional skills in [.github/skills](https://github.com/Azure/azure-sdk-for-rust/tree/main/.github/skills) or use `/{skill-name}` in Copilot; and prompts in [.github/prompts](https://github.com/Azure/azure-sdk-for-rust/tree/main/.github/prompts) or type `/{prompt-name}` in Copilot.
+In addition to [general instructions](https://github.com/Azure/azure-sdk-for-rust/blob/main/AGENTS.md), you can find additional skills in [.github/skills](https://github.com/Azure/azure-sdk-for-rust/tree/main/.github/skills) or use `/{skill-name}` in Copilot.
 
 To generate a new performance test, for example, you might prompt with:
 
 ```text
-Using /perf-test generate a perf test for SecretClient::get_secret.
+/create-perf-test generate a perf test for SecretClient::get_secret.
 ```
 
 For comprehensive guidance on how AI agents should interact with this repository, including workflows, automation boundaries, and safety guidelines, see [AGENTS.md](https://github.com/Azure/azure-sdk-for-rust/blob/main/AGENTS.md).
@@ -376,10 +376,32 @@ Once all of the above steps are met, the following process will be followed:
 
 ### Performance Testing
 
-Performance testing is supported via [criterion](https://bheisler.github.io/criterion.rs/book/criterion_rs.html)
-There are samples of performance tests under `sdk/core/azure_core/benches` folder.
-To execute the performance tests in `azure_core` folder you can run `cargo bench` in the `sdk/core/azure_core` folder.
-The output of the tests will be presented in the command line as well as saved under the `target/criterion` folder.
+See [sdk/storage/azure_storage_blob](https://github.com/Azure/azure-sdk-for-rust/tree/main/sdk/storage/azure_storage_blob) for examples of both types of performance tests.
+
+#### Benchmarks
+
+For on-demand micro-benchmarks, use [criterion](https://bheisler.github.io/criterion.rs/book/criterion_rs.html). Benchmark files go under `benches/` in the crate directory. Add the following to `Cargo.toml`:
+
+```toml
+[[bench]]
+name = "{bench-name}"
+harness = false
+```
+
+criterion requires `harness = false` to supply its own test harness.
+
+#### Performance Tests
+
+For scheduled performance tests that are compared across languages and tracked for regressions, use `azure_core_test::perf::PerfRunner`. These files go under `perf/` in the crate directory. Add the following to `Cargo.toml`:
+
+```toml
+[[bench]]
+name = "perf"
+path = "perf/perf_tests.rs"
+harness = false
+```
+
+Use the `/create-perf-test` skill to generate a new performance test.
 
 ## Releases