Revert "Fix pk_range_cache to use .item_by_rid() for correct URL fetching"#4040
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Reverts a previous change around how PartitionKeyRangeCache builds container links and handles routing-map fetch failures.
Changes:
- Switches container link construction back from
.item_by_rid(collection_rid)to.item(collection_rid). - Removes warning logs when routing-map fetch fails.
- Removes tests (and related cspell allowlist entries) that validated RID URL encoding behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| sdk/cosmos/azure_data_cosmos/src/routing/partition_key_range_cache.rs | Reverts RID-based link building, removes routing-map failure warning log, and deletes related tests. |
| sdk/cosmos/.cspell.json | Removes spellcheck allowlist entries that were only used by the deleted tests. |
analogrelay
approved these changes
Mar 25, 2026
github-project-automation
Bot
moved this from Todo
to Approved
in CosmosDB Rust SDK and Driver
github-project-automation
Bot
moved this from Approved
to Done
in CosmosDB Rust SDK and Driver
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #4032. Accidentally merged into main.