fix: remove unintentional default-features=false for azure_data_cosmos workspace dep#4219
Merged
tvaron3 merged 1 commit intoApr 20, 2026
Conversation
…s workspace dep The merge commit e753b8e ("Merge branch 'main' into release/azure_data_cosmos-previews") introduced a new [workspace.dependencies.azure_data_cosmos] block with default-features = false. This block did not exist in either merge parent — it was created during conflict resolution, modeled after the azure_data_cosmos_driver block. With default-features disabled, the reqwest feature is no longer enabled for downstream crates like azure_data_cosmos_perf. This causes a compilation failure because cosmos_client_builder.rs uses COSMOS_ALLOWED_HEADERS and AZURE_COSMOS_PER_PARTITION_CIRCUIT_BREAKER_ENABLED unconditionally, but their imports are gated behind #[cfg(feature = "reqwest")]. This also broke the AKS perf CronJob (cosmos-perf-updater) in rg-cosmos-perf-pr4159: the updater detected the new commit and attempted to rebuild, but the build fails with: error[E0425]: cannot find value COSMOS_ALLOWED_HEADERS in this scope error[E0425]: cannot find value AZURE_COSMOS_PER_PARTITION_CIRCUIT_BREAKER_ENABLED in this scope Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
tvaron3
requested review from
RickWinter,
heaths and
ronniegeraghty
as code owners
tvaron3
added
the
Client
tvaron3
added
Cosmos
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a workspace feature-resolution regression by restoring azure_data_cosmos’s default features when consumed via the root workspace dependency, preventing downstream workspace crates (notably azure_data_cosmos_perf) from losing the reqwest feature unintentionally.
Changes:
- Remove
default-features = falsefrom[workspace.dependencies.azure_data_cosmos]in the workspaceCargo.toml.
github-project-automation
Bot
moved this from Todo
to Approved
in CosmosDB Go/Rust Crew
github-project-automation
Bot
moved this from Approved
to Done
in CosmosDB Go/Rust Crew
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The merge commit e753b8e ("Merge branch 'main' into release/azure_data_cosmos-previews") introduced a new
[workspace.dependencies.azure_data_cosmos]block withdefault-features = false. This block did not exist in either merge parent — it was created during conflict resolution, modeled after theazure_data_cosmos_driverblock which legitimately disables defaults.With default features disabled, the
reqwestfeature is no longer enabled for downstream workspace crates likeazure_data_cosmos_perf. This causes a compilation failure becausecosmos_client_builder.rsusesCOSMOS_ALLOWED_HEADERSandAZURE_COSMOS_PER_PARTITION_CIRCUIT_BREAKER_ENABLEDunconditionally, but their imports are gated behind#[cfg(feature = "reqwest")]:Impact
This broke the AKS perf CronJob (
cosmos-perf-updater) inrg-cosmos-perf-pr4159. The updater correctly detected the new commit and attempted to rebuild, but the Docker image build fails due to the compilation error above. The perf workload is stuck on commit0b99c1158and cannot auto-update.Fix
Remove
default-features = falsefrom the[workspace.dependencies.azure_data_cosmos]block. This restores the default feature set (which includesreqwest) and allows the perf crate to compile.Verification
mainbranch does not have a[workspace.dependencies.azure_data_cosmos]block at allazure_data_cosmoscrate's default features includereqwest, which is required for the unconditional use ofCOSMOS_ALLOWED_HEADERSandAZURE_COSMOS_PER_PARTITION_CIRCUIT_BREAKER_ENABLED