Remove explicit version on azure_core_opentelemetry#4276
Merged
Conversation
Since it was only a dev-dependency, we don't actually need the version and it's causing problems when running: ```sh cargo package --locked --allow-dirty --package azure_storage_blob --package azure_storage_queue --package azure_core --package typespec_client_core ``` Becuase we're not simulating a publish of it, azure_storage_blob would fail.
heaths
requested review from
LarryOsterman,
RickWinter and
ronniegeraghty
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the explicit version for the azure_core_opentelemetry workspace dependency to prevent cargo package from failing when packaging publishable crates that only use it as a dev-dependency.
Changes:
- Remove the pinned
version = "0.10.0"from[workspace.dependencies.azure_core_opentelemetry]so it remains path-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since it was only a dev-dependency, we don't actually need the version and it's causing problems when running:
Becuase we're not simulating a publish of it, azure_storage_blob would fail.