Clean up post merge of release/azure_data_cosmos-previews#4441
Merged
analogrelay merged 4 commits intoMay 26, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Cleans up Cosmos workspace configuration and documentation after merging the release/azure_data_cosmos-previews branch back to main, aligning Cargo dependency declarations and removing stale spellcheck entries.
Changes:
- Switch Cosmos crate cross-dependencies from
workspace = trueto explicitpathdependencies. - Remove Cosmos workspace-dependency entries from the root
Cargo.tomland updateCargo.lockaccordingly. - Minor docs/spellcheck/ignore-file hygiene updates (hedging spec wording/formatting, cspell dictionary, Cosmos-local
.gitignore).
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/cosmos/azure_data_cosmos/Cargo.toml | Changes driver dependency to a path dependency (incl. dev-dep redeclare). |
| sdk/cosmos/azure_data_cosmos_perf/Cargo.toml | Points perf tool at local azure_data_cosmos via path. |
| sdk/cosmos/azure_data_cosmos_driver/docs/HEDGING_SPEC.md | Formatting tweaks + wording update. |
| sdk/cosmos/azure_data_cosmos_driver/Cargo.toml | Changes macros dependency to a path dependency. |
| sdk/cosmos/.gitignore | Ignores .temp/ under sdk/cosmos. |
| Cargo.toml | Removes workspace dependency entries for Cosmos crates. |
| Cargo.lock | Removes stale registry entry and reflects workspace/path resolution changes. |
| .vscode/cspell.json | Dedupes/reorders words and adds a few new terms. |
Comments suppressed due to low confidence (1)
sdk/cosmos/azure_data_cosmos/Cargo.toml:53
- Same issue for the dev-dependency re-declaration of
azure_data_cosmos_driver: if this crate is published, path-only dependencies make the published manifest invalid for consumers. Include aversionalongsidepath(keepingdefault-features = falseand the internal feature) or useworkspace = true+ workspace dependency metadata.
# this entry only adds the internal test feature.
azure_data_cosmos_driver = { path = "../azure_data_cosmos_driver", default-features = false, features = [
"__internal_test_diagnostics_construction",
] }
heaths
approved these changes
May 20, 2026
heaths
left a comment
Member
There was a problem hiding this comment.
I'll not block on my comment in case I'm wrong, but I don't think I am. Still, won't be a problem until you're ready to ship.
73ef546 to
7f84151
Compare
heaths
approved these changes
May 20, 2026
Pilchie
reviewed
May 20, 2026
heaths
approved these changes
May 21, 2026
heaths
reviewed
May 26, 2026
ae87ae4 to
893fa39
Compare
heaths
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the feedback from #4429