Skip to content

Clean up post merge of release/azure_data_cosmos-previews#4441

Merged
analogrelay merged 4 commits into
Azure:mainfrom
analogrelay:ashleyst/clean-up-post-merge
May 26, 2026
Merged

Clean up post merge of release/azure_data_cosmos-previews#4441
analogrelay merged 4 commits into
Azure:mainfrom
analogrelay:ashleyst/clean-up-post-merge

Conversation

@analogrelay

Copy link
Copy Markdown
Member

Addresses the feedback from #4429

Copilot AI review requested due to automatic review settings May 20, 2026 20:45
@github-actions github-actions Bot added the Cosmos The azure_cosmos crate label May 20, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Cleans up Cosmos workspace configuration and documentation after merging the release/azure_data_cosmos-previews branch back to main, aligning Cargo dependency declarations and removing stale spellcheck entries.

Changes:

  • Switch Cosmos crate cross-dependencies from workspace = true to explicit path dependencies.
  • Remove Cosmos workspace-dependency entries from the root Cargo.toml and update Cargo.lock accordingly.
  • Minor docs/spellcheck/ignore-file hygiene updates (hedging spec wording/formatting, cspell dictionary, Cosmos-local .gitignore).

Reviewed changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
sdk/cosmos/azure_data_cosmos/Cargo.toml Changes driver dependency to a path dependency (incl. dev-dep redeclare).
sdk/cosmos/azure_data_cosmos_perf/Cargo.toml Points perf tool at local azure_data_cosmos via path.
sdk/cosmos/azure_data_cosmos_driver/docs/HEDGING_SPEC.md Formatting tweaks + wording update.
sdk/cosmos/azure_data_cosmos_driver/Cargo.toml Changes macros dependency to a path dependency.
sdk/cosmos/.gitignore Ignores .temp/ under sdk/cosmos.
Cargo.toml Removes workspace dependency entries for Cosmos crates.
Cargo.lock Removes stale registry entry and reflects workspace/path resolution changes.
.vscode/cspell.json Dedupes/reorders words and adds a few new terms.
Comments suppressed due to low confidence (1)

sdk/cosmos/azure_data_cosmos/Cargo.toml:53

  • Same issue for the dev-dependency re-declaration of azure_data_cosmos_driver: if this crate is published, path-only dependencies make the published manifest invalid for consumers. Include a version alongside path (keeping default-features = false and the internal feature) or use workspace = true + workspace dependency metadata.
# this entry only adds the internal test feature.
azure_data_cosmos_driver = { path = "../azure_data_cosmos_driver", default-features = false, features = [
  "__internal_test_diagnostics_construction",
] }

Comment thread sdk/cosmos/azure_data_cosmos/Cargo.toml Outdated
Comment thread sdk/cosmos/azure_data_cosmos_driver/Cargo.toml Outdated
Comment thread sdk/cosmos/azure_data_cosmos_driver/docs/HEDGING_SPEC.md

@heaths heaths left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll not block on my comment in case I'm wrong, but I don't think I am. Still, won't be a problem until you're ready to ship.

Comment thread sdk/cosmos/azure_data_cosmos/Cargo.toml Outdated
@analogrelay analogrelay force-pushed the ashleyst/clean-up-post-merge branch from 73ef546 to 7f84151 Compare May 20, 2026 21:08
Comment thread sdk/cosmos/azure_data_cosmos_driver/Cargo.toml

@tvaron3 tvaron3 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread eng/scripts/verify-dependencies.rs Outdated
@analogrelay analogrelay force-pushed the ashleyst/clean-up-post-merge branch from ae87ae4 to 893fa39 Compare May 26, 2026 20:22
@analogrelay analogrelay merged commit b9e7d54 into Azure:main May 26, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Cosmos The azure_cosmos crate

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants