From 5d6def79b48715d6b81255dae6001986001ec998 Mon Sep 17 00:00:00 2001 From: Travis Prescott Date: Fri, 10 Jul 2026 12:12:34 -0700 Subject: [PATCH 1/3] Make failures report errors. --- eng/common/scripts/Create-APIReview.ps1 | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/eng/common/scripts/Create-APIReview.ps1 b/eng/common/scripts/Create-APIReview.ps1 index 86b95ed0e55..813a384231c 100644 --- a/eng/common/scripts/Create-APIReview.ps1 +++ b/eng/common/scripts/Create-APIReview.ps1 @@ -337,10 +337,10 @@ function ProcessPackage($packageInfo) { if (!$apiStatus.IsApproved) { - Write-Host "Package version $($version) is GA and automatic API Review is not yet approved for package $($packageInfo.ArtifactName)." - Write-Host "Build and release is not allowed for GA package without API review approval." - Write-Host "You will need to queue another build to proceed further after API review is approved" - Write-Host "You can check http://aka.ms/azsdk/engsys/apireview/faq for more details on API Approval." + Write-Error "Package version $($version) is GA and automatic API Review is not yet approved for package $($packageInfo.ArtifactName)." + Write-Error "Build and release is not allowed for GA package without API review approval." + Write-Error "You will need to queue another build to proceed further after API review is approved" + Write-Error "You can check http://aka.ms/azsdk/engsys/apireview/faq for more details on API Approval." } return 1 } @@ -437,7 +437,7 @@ foreach($pkg in $responses.keys) { if ($responses[$pkg] -eq 1) { - Write-Host "API changes are not approved for $($pkg)" + Write-Error "API changes are not approved for $($pkg)" $exitCode = 1 } } From c7b001d41cf17533a543ea211b6472bebef497a4 Mon Sep 17 00:00:00 2001 From: Travis Prescott Date: Tue, 21 Jul 2026 14:04:24 -0700 Subject: [PATCH 2/3] Code review feedback. --- eng/common/scripts/Create-APIReview.ps1 | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/eng/common/scripts/Create-APIReview.ps1 b/eng/common/scripts/Create-APIReview.ps1 index 813a384231c..7f6f8502168 100644 --- a/eng/common/scripts/Create-APIReview.ps1 +++ b/eng/common/scripts/Create-APIReview.ps1 @@ -337,10 +337,10 @@ function ProcessPackage($packageInfo) { if (!$apiStatus.IsApproved) { - Write-Error "Package version $($version) is GA and automatic API Review is not yet approved for package $($packageInfo.ArtifactName)." - Write-Error "Build and release is not allowed for GA package without API review approval." - Write-Error "You will need to queue another build to proceed further after API review is approved" - Write-Error "You can check http://aka.ms/azsdk/engsys/apireview/faq for more details on API Approval." + Write-Error "Package version $($version) is GA and automatic API Review is not yet approved for package $($packageInfo.ArtifactName)." -ErrorAction Continue + Write-Error "Build and release is not allowed for GA package without API review approval." -ErrorAction Continue + Write-Error "You will need to queue another build to proceed further after API review is approved" -ErrorAction Continue + Write-Error "You can check http://aka.ms/azsdk/engsys/apireview/faq for more details on API Approval." -ErrorAction Continue } return 1 } From 345129458e1b73e5426ae483fc93ed38d75d9e4e Mon Sep 17 00:00:00 2001 From: Travis Prescott Date: Tue, 21 Jul 2026 14:34:02 -0700 Subject: [PATCH 3/3] Apply suggestions from code review Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --- eng/common/scripts/Create-APIReview.ps1 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/eng/common/scripts/Create-APIReview.ps1 b/eng/common/scripts/Create-APIReview.ps1 index 7f6f8502168..53de649a633 100644 --- a/eng/common/scripts/Create-APIReview.ps1 +++ b/eng/common/scripts/Create-APIReview.ps1 @@ -340,7 +340,7 @@ function ProcessPackage($packageInfo) Write-Error "Package version $($version) is GA and automatic API Review is not yet approved for package $($packageInfo.ArtifactName)." -ErrorAction Continue Write-Error "Build and release is not allowed for GA package without API review approval." -ErrorAction Continue Write-Error "You will need to queue another build to proceed further after API review is approved" -ErrorAction Continue - Write-Error "You can check http://aka.ms/azsdk/engsys/apireview/faq for more details on API Approval." -ErrorAction Continue + Write-Error "You can check https://aka.ms/azsdk/engsys/apireview/faq for more details on API Approval." -ErrorAction Continue } return 1 } @@ -437,7 +437,7 @@ foreach($pkg in $responses.keys) { if ($responses[$pkg] -eq 1) { - Write-Error "API changes are not approved for $($pkg)" + Write-Error "API changes are not approved for $($pkg)" -ErrorAction Continue $exitCode = 1 } }