You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Make Create-APIReview report Errors when API is not approved (#16323)
* Make failures report errors.
* Code review feedback.
* Apply suggestions from code review
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
---------
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copy file name to clipboardExpand all lines: eng/common/scripts/Create-APIReview.ps1
+5-5Lines changed: 5 additions & 5 deletions
Original file line number
Diff line number
Diff line change
@@ -337,10 +337,10 @@ function ProcessPackage($packageInfo)
337
337
{
338
338
if (!$apiStatus.IsApproved)
339
339
{
340
-
Write-Host"Package version $($version) is GA and automatic API Review is not yet approved for package $($packageInfo.ArtifactName)."
341
-
Write-Host"Build and release is not allowed for GA package without API review approval."
342
-
Write-Host"You will need to queue another build to proceed further after API review is approved"
343
-
Write-Host"You can check http://aka.ms/azsdk/engsys/apireview/faq for more details on API Approval."
340
+
Write-Error"Package version $($version) is GA and automatic API Review is not yet approved for package $($packageInfo.ArtifactName)."-ErrorAction Continue
341
+
Write-Error"Build and release is not allowed for GA package without API review approval."-ErrorAction Continue
342
+
Write-Error"You will need to queue another build to proceed further after API review is approved"-ErrorAction Continue
343
+
Write-Error"You can check https://aka.ms/azsdk/engsys/apireview/faq for more details on API Approval."-ErrorAction Continue
344
344
}
345
345
return1
346
346
}
@@ -437,7 +437,7 @@ foreach($pkg in $responses.keys)
437
437
{
438
438
if ($responses[$pkg] -eq1)
439
439
{
440
-
Write-Host"API changes are not approved for $($pkg)"
440
+
Write-Error"API changes are not approved for $($pkg)"-ErrorAction Continue
0 commit comments