[azsdk-cli] Unified the path parameter#12067
Merged
Merged
Conversation
raych1
requested review from
benbp,
jeo02,
l0lawrence,
maririos,
praveenkuttappan,
richardpark-msft,
samvaity,
scbedd,
smw-ms and
timovv
as code owners
September 12, 2025 21:27
github-actions
Bot
added
the
azsdk-cli
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR unifies the path parameter handling across all GitHelper functions by accepting any path within a repository folder and consistently calling DiscoverRepoRoot() internally to find the repository root.
- Renamed all
pathparameters topathInRepofor clarity and consistency - Updated method implementations to call
DiscoverRepoRoot()before creating Repository instances - Added comprehensive XML documentation for all public methods
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| GitHelper.cs | Updated interface and implementation to use consistent pathInRepo parameter naming, added repo root discovery calls, and comprehensive XML documentation |
| GitHelperTests.cs | Added new test cases for subdirectory path handling and updated existing tests to reflect new exception types |
benbp
reviewed
Sep 15, 2025
praveenkuttappan
approved these changes
Sep 16, 2025
benbp
approved these changes
Sep 16, 2025
raych1
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unified the
pathparameter of all the functions inGitHelper:DiscoverRepoRoot()internally to find the repo root@benbp @praveenkuttappan could you review this PR?