Skip to content

Add evaluation test case for adding optional body to ARM action#15282

Merged
lirenhe merged 5 commits into
mainfrom
chatbot-new-testcase
Jul 22, 2026
Merged

Add evaluation test case for adding optional body to ARM action#15282
lirenhe merged 5 commits into
mainfrom
chatbot-new-testcase

Conversation

@lirenhe

@lirenhe lirenhe commented Apr 24, 2026

Copy link
Copy Markdown
Member

Add new Q&A evaluation test case to \ ypespec_core.jsonl\ covering how to add an optional body parameter to an existing ARM TypeSpec action operation in a new API version.

Changes:

  • \ ests/typespec_core.jsonl: New test case with 15 expected knowledges and 7 expected references

  • esults/typespec-test.json: Evaluation results for the new test case

Test case summary:

  • Question: How to add an optional request body to an existing ARM action that currently takes \�oid\
  • Answer: Use \OptionalRequestBody = true\ in a new API version, keeping the same action/operationId

Note: This test case does not work well in the current infrastructure but it works well in the new agentic framework.

@lirenhe
lirenhe force-pushed the chatbot-new-testcase branch from 3719c84 to 2bc964f Compare April 24, 2026 10:10
Add new test case covering how to add an optional body parameter to an
existing ARM TypeSpec action operation in a new API version. Includes
evaluation results in typespec-test.json.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@lirenhe
lirenhe force-pushed the chatbot-new-testcase branch from 2bc964f to 9d03fce Compare April 24, 2026 10:14
@lirenhe

lirenhe commented Apr 24, 2026

Copy link
Copy Markdown
Member Author

Create this PR as a draft that capture the current step. this would be updated when the new agent framework get merged.

@github-actions

Copy link
Copy Markdown

Hi @lirenhe. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@github-actions github-actions Bot added the no-recent-activity There has been no recent activity on this issue. label Jul 10, 2026
@lirenhe

lirenhe commented Jul 10, 2026

Copy link
Copy Markdown
Member Author

do not close this item. It needs to be migrated to the new framework.

@github-actions github-actions Bot removed the no-recent-activity There has been no recent activity on this issue. label Jul 10, 2026
@lirenhe

lirenhe commented Jul 22, 2026

Copy link
Copy Markdown
Member Author

@copilot resolve the merge conflicts in this pull request

Co-authored-by: lirenhe <9100546+lirenhe@users.noreply.github.com>

Copilot AI commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

@copilot resolve the merge conflicts in this pull request

Resolved the merge conflicts in commit 0776952. The optional ARM action body testcase is now migrated into evaluation_datasets/basic/typespec.jsonl, and the legacy conflicted tests/typespec_core.jsonl path has been removed to match the current framework layout.

lirenhe and others added 2 commits July 22, 2026 14:25
Rerun the case added in PR #15282 against the current agentic bot and
refresh its results/typespec-test.json entry: similarity 5, groundedness 5,
response_completeness 4 (all pass), overall_score 6.6, with real grader
reasons. Previously the case graded N/A under the old infrastructure.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 49e51257-81dd-47bf-aada-544a4b70416f
@lirenhe
lirenhe marked this pull request as ready for review July 22, 2026 06:27
@lirenhe
lirenhe requested a review from chunyu3 as a code owner July 22, 2026 06:27
Copilot AI review requested due to automatic review settings July 22, 2026 06:27
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
65 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new TypeSpec Q&A evaluation testcase covering how to evolve an ARM action by introducing an optional request body in a new API version (via OptionalRequestBody = true), and updates the checked-in evaluation results to include the new testcase.

Changes:

  • Added a new testcase entry to the TypeSpec evaluation dataset (typespec.jsonl).
  • Added the corresponding testcase result block to typespec-test.json and incremented total_evals.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File Description
tools/sdk-ai-bots/azure-sdk-qa-bot-evaluation/evaluation_datasets/basic/typespec.jsonl Adds the new “optional body on existing ARM action” testcase to the curated TypeSpec dataset.
tools/sdk-ai-bots/azure-sdk-qa-bot-evaluation/results/typespec-test.json Records evaluation output for the new testcase and updates aggregate counts.

@lirenhe

lirenhe commented Jul 22, 2026

Copy link
Copy Markdown
Member Author

/check-enforcer override

@lirenhe
lirenhe merged commit 4097885 into main Jul 22, 2026
7 checks passed
@lirenhe
lirenhe deleted the chatbot-new-testcase branch July 22, 2026 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants