[APIView SPA] Show prominent 'Approved' status pill for non-architect viewers (#14724)#15595
Open
helen229 wants to merge 4 commits into
Open
[APIView SPA] Show prominent 'Approved' status pill for non-architect viewers (#14724)#15595helen229 wants to merge 4 commits into
helen229 wants to merge 4 commits into
Conversation
… viewers (#14724) When an API revision or first release is approved, non-architect users (users without language-approver permission) now see a disabled green 'Approved' pill in the right-side Approval panel. The pill mirrors the green Approve button so the approval status is unmissable. Architect view is unchanged. Fixes #14724
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the APIView Angular SPA approval panel to make “approved” states visually prominent for non-architect viewers by rendering a disabled green pill in the same location where architects see approval action buttons.
Changes:
- Add disabled “Approved” / “First Release Approved” pill UI for users who cannot approve for the review language, when approval already exists.
- Add
.btn-approved-pillstyling using existing success theme tokens for consistent light/dark mode rendering.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/dotnet/APIView/ClientSPA/src/app/_components/review-page-options/review-page-options.component.html | Adds conditional rendering for the new disabled approved-status pills in the Approval panel. |
| src/dotnet/APIView/ClientSPA/src/app/_components/review-page-options/review-page-options.component.scss | Adds styling for the approved-status pill to match existing success UI theming. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #14724.
When an API revision or the first release is approved, non-architect viewers (users without language-approver permission for the review's language) now see a disabled green Approved pill in the right-side Approval panel — in the same slot where an architect would see the green Approve button. This makes the approval status unmissable for downstream consumers (PMs, partner teams, doc reviewers) who previously only saw a small grey
Approved by:line.Behavior
Approvedpill above the existingApproved by: <names>text.First Release Approvedpill above the existingApproved for first release by: <name>text.Implementation
Two files touched in the Angular SPA, no backend changes:
review-page-options.component.html— two new<ng-container *ngIf="!canApproveForReviewLanguage ...">blocks rendering the pill.review-page-options.component.scss— new.btn-approved-pillclass using existing theme tokens (--alert-success-bg,--alert-success-color,--success-color) so light/dark mode are both covered automatically.Testing
Screenshots