Skip to content

[APIView SPA] Show prominent 'Approved' status pill for non-architect viewers (#14724)#15595

Open
helen229 wants to merge 4 commits into
mainfrom
fix/14724-approved-revision-visual-treatment
Open

[APIView SPA] Show prominent 'Approved' status pill for non-architect viewers (#14724)#15595
helen229 wants to merge 4 commits into
mainfrom
fix/14724-approved-revision-visual-treatment

Conversation

@helen229
Copy link
Copy Markdown
Member

@helen229 helen229 commented May 11, 2026

Summary

Fixes #14724.

When an API revision or the first release is approved, non-architect viewers (users without language-approver permission for the review's language) now see a disabled green Approved pill in the right-side Approval panel — in the same slot where an architect would see the green Approve button. This makes the approval status unmissable for downstream consumers (PMs, partner teams, doc reviewers) who previously only saw a small grey Approved by: line.

Behavior

  • Architect view (can approve for the review's language): unchanged. They still see the Approve / Approve first release buttons and the small approver list.
  • Non-architect view, API revision approved: new green disabled Approved pill above the existing Approved by: <names> text.
  • Non-architect view, first release approved: new green disabled First Release Approved pill above the existing Approved for first release by: <name> text.

Implementation

Two files touched in the Angular SPA, no backend changes:

  • review-page-options.component.html — two new <ng-container *ngIf="!canApproveForReviewLanguage ..."> blocks rendering the pill.
  • review-page-options.component.scss — new .btn-approved-pill class using existing theme tokens (--alert-success-bg, --alert-success-color, --success-color) so light/dark mode are both covered automatically.

Testing

  • Verified locally by temporarily inverting the condition to render the pills for an architect (then reverted).
  • Visual confirmed against a first-release-approved review; theme tokens render correctly in both light and dark.

Screenshots

image image

… viewers (#14724)

When an API revision or first release is approved, non-architect users (users without language-approver permission) now see a disabled green 'Approved' pill in the right-side Approval panel. The pill mirrors the green Approve button so the approval status is unmissable. Architect view is unchanged.

Fixes #14724
Copilot AI review requested due to automatic review settings May 11, 2026 22:43
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the APIView Angular SPA approval panel to make “approved” states visually prominent for non-architect viewers by rendering a disabled green pill in the same location where architects see approval action buttons.

Changes:

  • Add disabled “Approved” / “First Release Approved” pill UI for users who cannot approve for the review language, when approval already exists.
  • Add .btn-approved-pill styling using existing success theme tokens for consistent light/dark mode rendering.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/dotnet/APIView/ClientSPA/src/app/_components/review-page-options/review-page-options.component.html Adds conditional rendering for the new disabled approved-status pills in the Approval panel.
src/dotnet/APIView/ClientSPA/src/app/_components/review-page-options/review-page-options.component.scss Adds styling for the approved-status pill to match existing success UI theming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[APIView UI] Improve visual treatment for approved revision status (non-architect view)

2 participants