ci(tsp-client-tests): pin contents: read#15613
Open
arpitjain099 wants to merge 1 commit into
Open
Conversation
Last workflow in .github/workflows here without a top-level permissions block. tsp-client tests only check out, npm ci/build/test/format - no GitHub API surface. Matches eng-common-tsp-client-test.yml and the other already-hardened sibling workflows. Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
github-actions
Bot
added
Community Contribution
|
Thank you for your contribution @arpitjain099! We will review the pull request and get back to you soon. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR completes workflow-level least-privilege for the repo by adding an explicit top-level permissions: block to the remaining workflow that lacked one, ensuring the default GITHUB_TOKEN scope is limited to what the workflow actually needs.
Changes:
- Add workflow-level
permissions: contents: readto.github/workflows/tsp-client-tests.yml.
arpitjain099
force-pushed
the
ci/add-permissions
branch
from
1d582ae to
20a61dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Round out workflow-level least-privilege in this repo.
tsp-client-tests.ymlwas the last workflow under.github/workflows/without a top-levelpermissions:block - all 11 siblings already declare one (e.g.eng-common-tsp-client-test.yml,event.yml,scheduled-event-processor.yml).The job only does
actions/checkout,actions/setup-node, andnpm ci / build / test / format:checkagainsttools/tsp-client. No GitHub API surface, socontents: readis the right scope.YAML re-parsed locally. No behavior change.