Skip to content

Make Create-APIReview report Errors when API is not approved#16323

Merged
tjprescott merged 3 commits into
mainfrom
apiviewFailureUpdate
Jul 21, 2026
Merged

Make Create-APIReview report Errors when API is not approved#16323
tjprescott merged 3 commits into
mainfrom
apiviewFailureUpdate

Conversation

@tjprescott

@tjprescott tjprescott commented Jul 10, 2026

Copy link
Copy Markdown
Member

Make the actual failure stand out in the logs without having to look into the detailed logs.

@tjprescott
tjprescott requested a review from a team as a code owner July 10, 2026 19:14
Copilot AI review requested due to automatic review settings July 10, 2026 19:14
Copilot AI reviewed Jul 10, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Create-APIReview.ps1 reporting so that API approval failures are emitted as PowerShell errors, making the underlying cause more visible in pipeline logs without needing to inspect detailed logs.

Changes:

  • Switch GA “API review not approved” messaging from Write-Host to Write-Error.
  • Switch the end-of-run summary line (“API changes are not approved…”) from Write-Host to Write-Error.

@azure-sdk-automation

azure-sdk-automation Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

This was referenced Jul 10, 2026
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@tjprescott
tjprescott requested a review from Copilot July 21, 2026 21:05
Copilot AI reviewed Jul 21, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

Comment thread eng/common/scripts/Create-APIReview.ps1 Outdated
Comment thread eng/common/scripts/Create-APIReview.ps1 Outdated
@azure-sdk-automation

azure-sdk-automation Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@tjprescott
Apply suggestions from code review
1599aad 
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@tjprescott
tjprescott requested a review from Copilot July 21, 2026 21:35
Copilot AI reviewed Jul 21, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@azure-sdk-automation

azure-sdk-automation Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

tjprescott added a commit to Azure/azure-sdk-for-js that referenced this pull request Jul 21, 2026
@azure-sdk-automation @tjprescott
Sync eng/common directory with azure-sdk-tools for PR 16323 (#39242)
1e8a169 
Sync eng/common directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#16323 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

---------

Co-authored-by: Travis Prescott <trpresco@microsoft.com>
Co-authored-by: Travis Prescott <tjprescott@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
tjprescott added a commit to Azure/azure-sdk-for-rust that referenced this pull request Jul 21, 2026
@azure-sdk-automation @tjprescott
Sync eng/common directory with azure-sdk-tools for PR 16323 (#4743)
228730c 
Sync eng/common directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#16323 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

---------

Co-authored-by: Travis Prescott <trpresco@microsoft.com>
Co-authored-by: Travis Prescott <tjprescott@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@tjprescott
tjprescott merged commit 6c69ee1 into main Jul 21, 2026
9 of 12 checks passed
@tjprescott
tjprescott deleted the apiviewFailureUpdate branch July 21, 2026 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments
@praveenkuttappan praveenkuttappan praveenkuttappan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tjprescott @praveenkuttappan