Skip to content

fix: Support Microsoft Graph Endpoints for AzureStackCloud#924

Open
wired010 wants to merge 1 commit into
Azure:mainfrom
wired010:jowr/support_sovereign_clouds
Open

fix: Support Microsoft Graph Endpoints for AzureStackCloud#924
wired010 wants to merge 1 commit into
Azure:mainfrom
wired010:jowr/support_sovereign_clouds

Conversation

@wired010

@wired010 wired010 commented May 3, 2023

Copy link
Copy Markdown

Reason for Change:
When using the AzureStackCloud environment, the desired Microsoft Graph endpoint/scope might not be one of the hard coded values for PublicCloud, USGovernmentCloud, ChinaCloud, or GermanCloud. If the msGraphEndpoint map doesn't contain an entry for the provided Azure environment, use the ResourceIdentifier value for MicrosoftGraph from the provided Azure environment. This allows users to override the endpoint/scope when needed.

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Issue Fixed:
Not Reported

Please answer the following questions with yes/no:

Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?

  • yes
  • no

Notes for Reviewers:

@wired010 wired010 changed the title Support Microsoft Graph Endpoints for AzureStackCloud fix: Support Microsoft Graph Endpoints for AzureStackCloud May 3, 2023
@wired010 wired010 force-pushed the jowr/support_sovereign_clouds branch 3 times, most recently from 1a36ba1 to ec55ed2 Compare May 3, 2023 22:34
@wired010 wired010 marked this pull request as ready for review May 3, 2023 22:40
@wired010 wired010 requested a review from aramase as a code owner May 3, 2023 22:40
When using the AzureStackCloud environment, the desired Microsoft Graph
endpoint/scope might not be one of the hard coded values for
PublicCloud, USGovernmentCloud, ChinaCloud, or GermanCloud. If the
msGraphEndpoint map doesn't contain an entry for the provided Azure
environment, use the ResourceIdentifier value for MicrosoftGraph from
the provided Azure environment. This allows users to override the
endpoint/scope when needed.
@wired010 wired010 force-pushed the jowr/support_sovereign_clouds branch from ec55ed2 to 2d49823 Compare May 5, 2023 12:52
@wired010 wired010 requested a review from enj as a code owner May 5, 2023 12:52

@aramase aramase left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wired010 Thank you for the PR! Since we don't have access to the sovereign cloud environment, can you confirm how you tested these changes and post any sample output you have from the testing?

@aramase

aramase commented Jul 24, 2023

Copy link
Copy Markdown
Member

@wired010 Thank you for the PR! Since we don't have access to the sovereign cloud environment, can you confirm how you tested these changes and post any sample output you have from the testing?

@wired010 bump on this one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants