Skip to content

AML pipeline component for MaaP self serve validation#3978

Closed
abhishekMS2024 wants to merge 33 commits into
mainfrom
abhisheku/maap_validation_component
Closed

AML pipeline component for MaaP self serve validation#3978
abhishekMS2024 wants to merge 33 commits into
mainfrom
abhisheku/maap_validation_component

Conversation

@abhishekMS2024
Copy link
Copy Markdown
Contributor

Validation Link: here

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 25, 2025

Test Results for assets-test

2 tests   2 ✅  1h 53m 14s ⏱️
2 suites  0 💤
2 files    0 ❌

Results for commit b1c61c8.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 25, 2025

Test Results for training-model-mgmt-unittests

45 tests   45 ✅  9s ⏱️
 1 suites   0 💤
 1 files     0 ❌

Results for commit b1c61c8.

♻️ This comment has been updated with latest results.

Comment thread assets/common/components/delete_endpoint/spec.yaml
Deploy a model to a workspace. The component works on compute with [MSI](https://learn.microsoft.com/en-us/azure/machine-learning/how-to-create-manage-compute-instance?tabs=python) attached.

environment: azureml://registries/azureml/environments/python-sdk-v2/versions/19
environment: azureml://registries/azureml/environments/python-sdk-v2/versions/28
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was also talk of needing to upgrade everything to skd v3, is that a prereq for this pr too?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current environment version for python-sdk-v2 is 28. After updating the python-sdk-v2 environment, the component was not updated with the new environment.

Comment thread assets/common/components/deploy_model/spec.yaml Outdated
Comment thread assets/common/src/deploy.py Outdated
parser.add_argument(
"--inference_response",
type=str,
help="Json file to save the inference response",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

json file containing expected inference response?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated this

Comment thread assets/common/src/deploy.py Outdated
Comment thread assets/common/src/deploy.py Outdated
logger.info("Saved deployment details in output json file.")

if response and args.inference_response:
with open(args.inference_response, "w") as outfile:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not add it above

spec: spec.yaml
categories:
[
"CommonBench Baselining",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldve been merged so lets work off of master

Copy link
Copy Markdown
Contributor Author

@abhishekMS2024 abhishekMS2024 Mar 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not merged yet. I have kept a different name.

skadooshhhh
skadooshhhh previously approved these changes Apr 10, 2025
@@ -0,0 +1,40 @@
$schema: https://azuremlschemas.azureedge.net/latest/commandComponent.schema.json
name: delete_endpoint
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets reuse these pls, can you pls post on System registry content channel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to publish Pull request containing new asset has been tested properly

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants