Skip to content

Adjusting validation to handle new and previous model schema #4171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
corymcc wants to merge 1 commit into from
Closed

Adjusting validation to handle new and previous model schema #4171

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions scripts/azureml-assets/azureml/assets/validate_assets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -700,7 +700,13 @@ def validate_model_scenario(
"""
error_count = 0
min_sku = model.properties.get(min_sku_prop_name, "").strip()
recommended_skus = model.properties.get(recommended_skus_prop_name, "").strip()
recommended_skus_value = model.properties.get(recommended_skus_prop_name, None)
if isinstance(recommended_skus_value, str):
recommended_skus = [sku.strip() for sku in recommended_skus_value.split(",") if sku.strip()]
elif isinstance(recommended_skus_value, list):
recommended_skus = [str(sku).strip() for sku in recommended_skus_value if str(sku).strip()]
else:
recommended_skus = []
compute_allowlists = set(model.tags.get(compute_allowlist_tags_name, []))

if not min_sku:
Expand All @@ -715,7 +721,6 @@ def validate_model_scenario(
_log_error(asset_file_name_with_path, f"{compute_allowlist_tags_name} is missing in model tags")
error_count += 1

recommended_skus = set([sku.strip() for sku in recommended_skus.split(",")])
if (recommended_skus != compute_allowlists):
a_minus_b = recommended_skus - compute_allowlists
b_minus_a = compute_allowlists - recommended_skus
Expand Down
Loading