Generate SAS token instead of checking container access#4184
Merged
Conversation
Test Results for assets-test0 tests 0 ✅ 0s ⏱️ Results for commit 0cc35d4. ♻️ This comment has been updated with latest results. |
Test Results for scripts-test79 tests 79 ✅ 8m 26s ⏱️ Results for commit 0cc35d4. ♻️ This comment has been updated with latest results. |
…ure/azureml-assets into lolarson/make-more-sas-tokens
vizhur
previously approved these changes
May 15, 2025
lykelly19
approved these changes
May 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR handles the case where a storage account has anonymous access disabled, but a container is still configured to allow it. If public access isn't allowed on the storage account and container, we'll just generate a SAS token.