Skip to content

Detect if MLFlow Model was updated#4207

Merged
lykelly19 merged 26 commits into
mainfrom
mlflow-model-tag-req
May 29, 2025
Merged

Detect if MLFlow Model was updated#4207
lykelly19 merged 26 commits into
mainfrom
mlflow-model-tag-req

Conversation

@lykelly19
Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 22, 2025

Test Results for assets-test

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit de114a3.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 23, 2025

Test Results for scripts-test

79 tests   79 ✅  8m 16s ⏱️
 1 suites   0 💤
 1 files     0 ❌

Results for commit de114a3.

♻️ This comment has been updated with latest results.

@lykelly19 lykelly19 removed the mlflow noncompliant exception Pull request contains MLFlow model has been approved for exception label May 23, 2025
vizhur
vizhur previously approved these changes May 29, 2025
Copy link
Copy Markdown
Contributor

@sophies927 sophies927 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me from a Foundry Local perspective! Just to confirm that I'm fully understanding the changes, this will only cause an error if MLFlow model is updated, but it looks like nothing will happen if a custom model variant with an MLFlow parent model (e.g., some of the Phi models) is updated, correct? And are there any plans to fully delete/remove MLFlow models entirely?

If no to both, local models will be unaffected since we only update/publish new versions for model variants.

@lykelly19
Copy link
Copy Markdown
Collaborator Author

lykelly19 commented May 29, 2025

This looks good to me from a Foundry Local perspective! Just to confirm that I'm fully understanding the changes, this will only cause an error if MLFlow model is updated, but it looks like nothing will happen if a custom model variant with an MLFlow parent model (e.g., some of the Phi models) is updated, correct? And are there any plans to fully delete/remove MLFlow models entirely?

If no to both, local models will be unaffected since we only update/publish new versions for model variants.

Correct, no impact for Foundry Local since those are all custom. We're still looking into what to do with existing MLFlow models, but right now just latest/new ones will be impacted by this gate update. You might've been added as a reviewer since I was ensuring a custom model wasn't impacted (and happened to choose a Foundry Local one), thanks for taking a look! :)

@lykelly19 lykelly19 merged commit 7156226 into main May 29, 2025
39 checks passed
@lykelly19 lykelly19 deleted the mlflow-model-tag-req branch May 29, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants