Skip to content

Fix for ev2 failure. #4240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
babu-namburi merged 1 commit into from
Jun 4, 2025
Merged

Fix for ev2 failure. #4240

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion assets/training/finetune_acft_hf_nlp/components/finetune/chat_completion/spec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ inputs:
enum:
- epoch
- steps
- "no"
- disable
description: The evaluation strategy to adopt during training. If set to "steps", either the `evaluation_steps_interval` or `eval_steps` needs to be specified, which helps to determine the step at which the model evaluation needs to be computed else evaluation happens at end of each epoch.

evaluation_steps_interval:
Expand Down
2 changes: 1 addition & 1 deletion ...ts/training/finetune_acft_hf_nlp/components/pipeline_components/chat_completion/spec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,7 @@ inputs:
enum:
- epoch
- steps
- "no"
- disable
description: The evaluation strategy to adopt during training. If set to "steps", either the `evaluation_steps_interval` or `eval_steps` needs to be specified, which helps to determine the step at which the model evaluation needs to be computed else evaluation happens at end of each epoch.

evaluation_steps_interval:
Expand Down
6 changes: 5 additions & 1 deletion assets/training/finetune_acft_hf_nlp/src/finetune/finetune.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,7 +442,7 @@ def get_parser():
type=str,
default="epoch",
choices=(
"no",
"disable",
"steps",
"epoch",
),
Expand Down Expand Up @@ -1275,6 +1275,10 @@ def finetune(args: Namespace):

validate_learning_rate(args)

# Fix: Ev2 rollout fails when using no as string in the spec.
if args.evaluation_strategy == 'disable':
args.evaluation_strategy = 'no'

if not hasattr(args, "eval_strategy"):
args.eval_strategy = args.evaluation_strategy
# validate early stop settings
Expand Down
Loading