Fix TypeError when evaluator returns None score for skipped/not-applicable results#5107
Merged
Conversation
Test Results for assets-test279 tests 279 ✅ 9s ⏱️ Results for commit ba2c49f. ♻️ This comment has been updated with latest results. |
ashaabansoliman
approved these changes
Jun 4, 2026
imatiach-msft
approved these changes
Jun 4, 2026
aprilk-ms
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When _return_not_applicable_result sets score=None (introduced in PR #5042), the math.isnan() check in _do_eval crashes with:
TypeError: must be real number, not NoneType
Guard math.isnan() with a None check so skipped/not-applicable results pass through correctly instead of raising an unhandled TypeError.
Affected evaluators: groundedness, coherence, fluency, retrieval, similarity.