Add real_ps_util_renames to real_process_watchdog to avoid c_pal link dependency

real_process_watchdog calls ps_util_terminate_process via LogCriticalAndTerminate.
By adding real_ps_util_renames.h, this becomes real_ps_util_terminate_process
which is provided by c_pal_reals (already linked in UTs). This eliminates the
need for downstream repos to link c_pal in unit tests solely for watchdog support.

Also fixes include order in int tests (timed_test_suite.h before umock_c.h)
so renames are not triggered and int tests use process_watchdog directly from
c_pal without needing any reals libraries.

Fixes gballoc_ll_passthrough_ut PCH include order (umock_c.h must come
before timed_test_suite.h for proper rename activation in UTs).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: parth21999

common/tests/threadpool_int/CMakeLists.txt

@@ -12,4 +12,4 @@ set(${theseTestsName}_c_files
 set(${theseTestsName}_h_files
 )
 
-build_test_artifacts(${theseTestsName} "tests/c_pal" ADDITIONAL_LIBS real_process_watchdog c_pal_ll_reals pal_interfaces c_pal)
+build_test_artifacts(${theseTestsName} "tests/c_pal" ADDITIONAL_LIBS c_pal_ll_reals pal_interfaces c_pal)

common/tests/threadpool_int/threadpool_int.c

@@ -13,6 +13,8 @@
 
 #include "testrunnerswitcher.h"
 
+#include "c_pal/timed_test_suite.h"
+
 #include "umock_c/umock_c.h" // IWYU pragma: keep
 
 #include "c_pal/timer.h"

interfaces/tests/srw_lock_int/CMakeLists.txt

@@ -12,5 +12,5 @@ set(${theseTestsName}_c_files
 set(${theseTestsName}_h_files
 )
 
-build_test_artifacts(${theseTestsName} "tests/c_pal/int" ADDITIONAL_LIBS real_process_watchdog c_pal_ll_reals c_pal)
+build_test_artifacts(${theseTestsName} "tests/c_pal/int" ADDITIONAL_LIBS c_pal_ll_reals c_pal)
 

interfaces/tests/srw_lock_int/srw_lock_int.c

@@ -6,11 +6,11 @@
 
 #include "testrunnerswitcher.h"
 
-#include "umock_c/umock_c.h" // IWYU pragma: keep
-
 #include "c_pal/srw_lock.h"
 #include "c_pal/timed_test_suite.h"
 
+#include "umock_c/umock_c.h" // IWYU pragma: keep
+
 static const char* TEST_LOCK_NAME = "test_lock";
 
 BEGIN_TEST_SUITE(TEST_SUITE_NAME_FROM_CMAKE)

interfaces/tests/srw_lock_ll_int/CMakeLists.txt

@@ -12,5 +12,5 @@ set(${theseTestsName}_c_files
 set(${theseTestsName}_h_files
 )
 
-build_test_artifacts(${theseTestsName} "tests/c_pal/int" ADDITIONAL_LIBS real_process_watchdog c_pal_ll_reals c_pal)
+build_test_artifacts(${theseTestsName} "tests/c_pal/int" ADDITIONAL_LIBS c_pal_ll_reals c_pal)
 

interfaces/tests/srw_lock_ll_int/srw_lock_ll_int.c

@@ -5,11 +5,11 @@
 
 #include "testrunnerswitcher.h"
 
-#include "umock_c/umock_c.h" // IWYU pragma: keep
-
 #include "c_pal/srw_lock_ll.h"
 #include "c_pal/timed_test_suite.h"
 
+#include "umock_c/umock_c.h" // IWYU pragma: keep
+
 BEGIN_TEST_SUITE(TEST_SUITE_NAME_FROM_CMAKE)
 
 TIMED_TEST_SUITE_INITIALIZE(suite_init, TIMED_TEST_DEFAULT_TIMEOUT_MS)

linux/linux_reals/real_process_watchdog.c

@@ -2,6 +2,7 @@
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 
 #include "real_interlocked_renames.h" // IWYU pragma: keep
+#include "real_ps_util_renames.h" // IWYU pragma: keep
 
 #include "real_process_watchdog_renames.h" // IWYU pragma: keep
 

win32/reals/real_process_watchdog.c

@@ -2,6 +2,7 @@
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 
 #include "real_interlocked_renames.h" // IWYU pragma: keep
+#include "real_ps_util_renames.h" // IWYU pragma: keep
 
 #include "real_process_watchdog_renames.h" // IWYU pragma: keep
 

win32/tests/gballoc_ll_passthrough_ut/gballoc_ll_passthrough_ut_pch.h

@@ -10,6 +10,9 @@
 
 #include "macro_utils/macro_utils.h"
 #include "testrunnerswitcher.h"
+
+#include "umock_c/umock_c.h"
+
 #include "c_pal/timed_test_suite.h"
 
 #endif // GBALLOC_LL_PASSTHROUGH_UT_PCH_H