Commit 571b6a3
Avoid starting web host in MCP stdio mode (#3676)
## Summary
`dab start --mcp-stdio` communicates over stdin/stdout, but the stdio
helper was calling `host.Start()`. That starts the web host and Kestrel,
so stdio mode still tried to bind the configured HTTP port. When the
port was occupied, the process exited before the MCP `initialize`
handshake.
The stdio path already initializes and registers MCP tools directly from
DI, so it can run the stdio JSON-RPC loop without starting Kestrel.
Fixes #3675.
## Changes
- Avoid starting the ASP.NET Core host when running the engine in MCP
stdio mode.
- Keep MCP tool registry initialization in the stdio path before running
the JSON-RPC loop.
- Dispose the host after the stdio loop exits without calling
`StartAsync()` or `StopAsync()`.
- Add a regression test that proves `RunMcpStdioHost()` does not call
`IHost.StartAsync()`/`StopAsync()`, still starts the stdio server loop,
and disposes the host.
## Verification
```bash
dotnet test src/Service.Tests/Azure.DataApiBuilder.Service.Tests.csproj --filter 'FullyQualifiedName~McpStdioHelperTests' -p:RuntimeIdentifiers= -p:UseAppHost=false
dotnet test src/Service.Tests/Azure.DataApiBuilder.Service.Tests.csproj --filter 'FullyQualifiedName~McpStdioHelperTests|FullyQualifiedName~McpStdioServerRunAsyncTests|FullyQualifiedName~McpStdioServerInitializeTests|FullyQualifiedName~McpStdioServerContentBlockTests|FullyQualifiedName~McpToolRegistryTests' -p:RuntimeIdentifiers= -p:UseAppHost=false
git diff --check
```
A runtime smoke also occupied `127.0.0.1:5155`, pointed
`ASPNETCORE_URLS` at that occupied port, and verified that the service
completed MCP `initialize` and `shutdown` over stdio without an
address-in-use error.
Co-authored-by: RubenCerna2079 <32799214+RubenCerna2079@users.noreply.github.com>1 parent a4505f8 commit 571b6a3
2 files changed
Lines changed: 129 additions & 14 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
76 | 76 | | |
77 | 77 | | |
78 | 78 | | |
79 | | - | |
80 | | - | |
81 | | - | |
82 | | - | |
83 | | - | |
84 | | - | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
85 | 85 | | |
86 | | - | |
| 86 | + | |
87 | 87 | | |
88 | | - | |
89 | | - | |
90 | | - | |
91 | | - | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
92 | 92 | | |
93 | | - | |
94 | | - | |
| 93 | + | |
95 | 94 | | |
96 | | - | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
97 | 101 | | |
98 | 102 | | |
99 | 103 | | |
0 commit comments