Potential fix for pull request finding

souvikghosh04 · Copilot · web-flow · commit 8d34456c01e4 · 2026-07-09T16:01:56.000+05:30
Co-authored-by: Copilot Autofix powered by AI &lt;175728472+Copilot@users.noreply.github.com&gt;
diff --git a/src/Azure.DataApiBuilder.Mcp/Core/DynamicCustomTool.cs b/src/Azure.DataApiBuilder.Mcp/Core/DynamicCustomTool.cs
@@ -442,13 +442,14 @@ private JsonElement BuildInputSchemaFromConfig()
         /// </summary>
         private static bool IsParameterRequired(bool? configuredRequired, bool hasDefault)
         {
-            if (configuredRequired is not null)
+            // If the engine can supply a default when the caller omits the parameter,
+            // it should not be advertised as required.
+            if (hasDefault)
             {
-                return configuredRequired.Value;
+                return false;
             }
 
-            // No explicit config: a parameter is required unless a default is available.
-            return !hasDefault;
+            return configuredRequired ?? true;
         }
 
         /// <summary>

Original file line number	Diff line number	Diff line change
`@@ -442,13 +442,14 @@ private JsonElement BuildInputSchemaFromConfig()`
`442`	`442`	`/// </summary>`
`443`	`443`	`private static bool IsParameterRequired(bool? configuredRequired, bool hasDefault)`
`444`	`444`	`{`
`445`		`- if (configuredRequired is not null)`
	`445`	`+ // If the engine can supply a default when the caller omits the parameter,`
	`446`	`+ // it should not be advertised as required.`
	`447`	`+ if (hasDefault)`
`446`	`448`	`{`
`447`		`- return configuredRequired.Value;`
	`449`	`+ return false;`
`448`	`450`	`}`
`449`	`451`
`450`		`- // No explicit config: a parameter is required unless a default is available.`
`451`		`- return !hasDefault;`
	`452`	`+ return configuredRequired ?? true;`
`452`	`453`	`}`
`453`	`454`
`454`	`455`	`/// <summary>`