Cherry-Pick: Add changes to fix Nuget Core Package Creation (#3633)

## Why make this change?

This change cherry-picks the PRs that fixes the new Nuget Core Package

## What is this change?

Cherry-picked PRs

- #3617
- #3620

## How was this tested?

Existing tests in cherry-pick cover new changes.

## Sample Request(s)

N/A

---------

Co-authored-by: aaronburtle <93220300+aaronburtle@users.noreply.github.com>
Co-authored-by: Aniruddh Munde <anmunde@microsoft.com>

Author: 3 people

scripts/notice-generation.ps1

@@ -19,8 +19,7 @@ $sqlClientSNILicenseFilePath = "$BuildSourcesDir/external_licenses/Microsoft.Dat
 $sqlClientSNILicense = Get-Content -Path $sqlClientSNILicenseFilePath -Raw
 
 # Replace erroneous copyright, using [System.IO.File] for better performance than Get-Content and Set-Content
-$content = [System.IO.File]::ReadAllText($noticeFilePath).Replace("(c) Microsoft 2023`r`n", "")
-$content = [System.IO.File]::ReadAllText($noticeFilePath).Replace("(c) Microsoft 2024`r`n", "")
+$content = [System.IO.File]::ReadAllText($noticeFilePath) -replace "\(c\) Microsoft (2023|2024)`r`n", ""
 
 # Prepare license content for writing to file.
 $sqlClientSNIComponentName = "`r`nMICROSOFT.DATA.SQLCLIENT.SNI`r`n`r`n"

src/Core/Azure.DataApiBuilder.Core.csproj

@@ -20,6 +20,9 @@
     <EmbedUntrackedSources>true</EmbedUntrackedSources>
     <PublishRepositoryUrl>true</PublishRepositoryUrl>
     <NoWarn>NU1603</NoWarn>
+
+    <!-- Run custom target during pack to add dependency files into the package. -->
+    <TargetsForTfmSpecificContentInPackage>$(TargetsForTfmSpecificContentInPackage);IncludeInternalDependenciesInPackage</TargetsForTfmSpecificContentInPackage>
   </PropertyGroup>
 
   <ItemGroup>
@@ -54,9 +57,15 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <ProjectReference Include="..\Auth\Azure.DataApiBuilder.Auth.csproj" />
-    <ProjectReference Include="..\Config\Azure.DataApiBuilder.Config.csproj" />
-    <ProjectReference Include="..\Service.GraphQLBuilder\Azure.DataApiBuilder.Service.GraphQLBuilder.csproj" />
+    <ProjectReference Include="..\Auth\Azure.DataApiBuilder.Auth.csproj">
+      <PrivateAssets Condition="'$(PrivatizeAssets)' == 'true'">all</PrivateAssets>
+    </ProjectReference>
+    <ProjectReference Include="..\Config\Azure.DataApiBuilder.Config.csproj">
+      <PrivateAssets Condition="'$(PrivatizeAssets)' == 'true'">all</PrivateAssets>
+    </ProjectReference>
+    <ProjectReference Include="..\Service.GraphQLBuilder\Azure.DataApiBuilder.Service.GraphQLBuilder.csproj">
+      <PrivateAssets Condition="'$(PrivatizeAssets)' == 'true'">all</PrivateAssets>
+    </ProjectReference>
   </ItemGroup>
 
   <ItemGroup>
@@ -66,4 +75,15 @@
     <None Include="..\..\nuget_core\NOTICE.txt" Pack="true" PackagePath="\" Condition="Exists('..\..\nuget_core\NOTICE.txt')" />
   </ItemGroup>
 
+  <Target Name="IncludeInternalDependenciesInPackage">
+    <ItemGroup>
+      <_InternalAssembly Include="$(OutputPath)Azure.DataApiBuilder.Auth.dll" />
+      <_InternalAssembly Include="$(OutputPath)Azure.DataApiBuilder.Config.dll" />
+      <_InternalAssembly Include="$(OutputPath)Azure.DataApiBuilder.Service.GraphQLBuilder.dll" />
+      <_InternalAssembly Include="$(OutputPath)Azure.DataApiBuilder.Product.dll" />
+
+      <TfmSpecificPackageFile Include="@(_InternalAssembly)" PackagePath="lib/$(TargetFramework)" />
+    </ItemGroup>
+  </Target>
+
 </Project>