Fix history events buildup from version reject#1220
Merged
Conversation
Contributor
|
Do you think we have sufficient test coverage for this? Wondering if it would be possible (and practical) to add a test that fails without this change. |
When an orchestration was being rejected due to a versioning mismatch an issue would cause the history events of the orchestration to build continuously. This was caused by the orchestration adding an OrchestrationStarted event before the versioning took place and was saved even on a rejected version. This change causes the versioning code to exit the process method entirely instead of just prematurely end the process loop. This avoids the commit of the history. Signed-off-by: halspang <halspang@microsoft.com>
halspang
force-pushed
the
halspang/fix_reject_history
branch
from
e550739 to
e587e35
Compare
Member
Author
|
@AnatoliB - Updated a test that looks at this scenario. I confirmed manually that it passes with this change and fails without it. |
cgillum
reviewed
May 23, 2025
cgillum
left a comment
cgillum
left a comment
Member
There was a problem hiding this comment.
I think the fix is 90% correct. See my one request below about changing the false value to true. Then I'll be ready to sign off.
Signed-off-by: halspang <halspang@microsoft.com>
cgillum
approved these changes
May 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an orchestration was being rejected due to a versioning mismatch an issue would cause the history events of the orchestration to build continuously. This was caused by the orchestration adding an OrchestrationStarted event before the versioning took place and was saved even on a rejected version.
This change causes the versioning code to exit the process method entirely instead of just prematurely end the process loop. This avoids the commit of the history.