Fix security scan findings in test and sample code#251
Open
lukat01 wants to merge 1 commit into
Open
Conversation
Address 7 Azure DevOps security findings across test utilities and PowerShell samples: - CommonTestUtils.cs (CA2301): Replace BinaryFormatter.Deserialize pragma suppression with a restrictive SerializationBinder (ExceptionRoundTripBinder) that only allows primitives, string, Exception, List<>/ReadOnlyCollection<>, and ElasticScale types. - Globals.cs (CSCAN-MSFT0090): Replace hardcoded test login password with a runtime-generated value. - MultiShardTestUtils.cs (CSCAN-GENERAL0060): Replace hardcoded test login password with a runtime-generated value. - PowerShell sample help (CSCAN-MSFT0090): Replace example passwords in comment-based help with the <my-sql-pwd-of-choice> placeholder in GetMappings.ps1, GetShards.ps1, ExecuteSampleSplitMerge.ps1, and SetupSampleSplitMergeEnvironment.ps1. Validated: exception serialization tests pass on net481, net6.0, and net8.0.
Author
|
@microsoft-github-policy-service agree company="Microsoft" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address 7 Azure DevOps security findings across test utilities and
PowerShell samples:
pragma suppression with a restrictive SerializationBinder
(ExceptionRoundTripBinder) that only allows primitives, string,
Exception, List<>/ReadOnlyCollection<>, and ElasticScale types.
with a runtime-generated value.
login password with a runtime-generated value.
comment-based help with the placeholder in
GetMappings.ps1, GetShards.ps1, ExecuteSampleSplitMerge.ps1, and
SetupSampleSplitMergeEnvironment.ps1.
Validated: exception serialization tests pass on net481, net6.0, and
net8.0.