fix: fix the appVersion default value that doesn't start with v (#483)

Author: ryanzhang-oss

.github/workflows/chart.yml

@@ -57,18 +57,19 @@ jobs:
         run: |
           set -euo pipefail
 
-          RELEASE_VERSION="${{ needs.export-registry.outputs.version }}"
-
+          RELEASE_TAG="${{ needs.export-registry.outputs.tag }}"
+          CHART_VERSION="${{ needs.export-registry.outputs.version }}"
           OCI_REGISTRY="${{ needs.export-registry.outputs.registry }}/charts"
-          make helm-push REGISTRY="${OCI_REGISTRY}" TAG="${RELEASE_VERSION}"
+
+          make helm-push REGISTRY="${OCI_REGISTRY}" TAG="${RELEASE_TAG}" CHART_VERSION="${CHART_VERSION}"
 
       - name: Verify chart appVersion matches release tag
         run: |
           set -euo pipefail
 
-          RELEASE_VERSION="${{ needs.export-registry.outputs.version }}"
-          CHART_VERSION="${RELEASE_VERSION}"
-          EXPECTED_APP_VERSION="${RELEASE_VERSION}"
+          RELEASE_TAG="${{ needs.export-registry.outputs.tag }}"
+          CHART_VERSION="${{ needs.export-registry.outputs.version }}"
+          EXPECTED_APP_VERSION="${RELEASE_TAG}"
 
           rm -rf .helm-verify
           mkdir -p .helm-verify

Makefile

@@ -235,10 +235,10 @@ push: ## Build and push all Docker images
 
 .PHONY: helm-push
 helm-push: ## Package and push Helm charts to OCI registry
-	helm package charts/hub-agent --version $(TAG) --app-version $(TAG) --destination .helm-packages
-	helm package charts/member-agent --version $(TAG) --app-version $(TAG) --destination .helm-packages
-	helm push .helm-packages/hub-agent-$(TAG).tgz oci://$(REGISTRY)
-	helm push .helm-packages/member-agent-$(TAG).tgz oci://$(REGISTRY)
+	helm package charts/hub-agent --version $(CHART_VERSION) --app-version $(TAG) --destination .helm-packages
+	helm package charts/member-agent --version $(CHART_VERSION) --app-version $(TAG) --destination .helm-packages
+	helm push .helm-packages/hub-agent-$(CHART_VERSION).tgz oci://$(REGISTRY)
+	helm push .helm-packages/member-agent-$(CHART_VERSION).tgz oci://$(REGISTRY)
 	rm -rf .helm-packages
 
 # By default, docker buildx create will pull image moby/buildkit:buildx-stable-1 and hit the too many requests error

charts/hub-agent/Chart.yaml

@@ -21,4 +21,4 @@ version: 0.1.0
 # incremented each time you make changes to the application. Versions are not expected to
 # follow Semantic Versioning. They should reflect the version the application is using.
 # It is recommended to use it with quotes.
-appVersion: "0.1.0"
+appVersion: "v0.1.0"