fix: revert serviceExport availability check#1090
Merged
ryanzhang-oss merged 2 commits intoAzure:mainfrom Mar 20, 2025
Merged
Conversation
britaniar
approved these changes
Mar 20, 2025
ryanzhang-oss
pushed a commit
to ryanzhang-oss/fleet
that referenced
this pull request
Apr 22, 2025
* Revert "address comments to fix bug (Azure#1080)" This reverts commit 9a376db. * Revert "feat: add svc export trackability (Azure#1061)" This reverts commit 22dc1a0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
reverted two commits since the condition is not reliable and the resource is not trackable.
git revert 9a376db
[revert-export b0efd02] Revert "address comments to fix bug (#1080)"
git revert 22dc1a0
Auto-merging go.mod
Auto-merging go.sum
Auto-merging pkg/utils/common.go
[revert-export 5e52ded] Revert "feat: add svc export trackability (#1061)"
Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer