fix: address the issue work applier has after disabling parallelism + add more log entries#1100
Conversation
|
Side note: additional test cases will be added in a separate PR, to control PR size. |
761be5f to
f3736c5
Compare
| nsUnstructured *unstructured.Unstructured | ||
| nsJSON []byte | ||
|
|
||
| configMap = &corev1.ConfigMap{ |
There was a problem hiding this comment.
Hi Ryan! This is used for the newly added decoding error test; for negative cases configMaps are a bit easier to handle than deployments.
zhiying-lin
left a comment
There was a problem hiding this comment.
i thought this PR is fixing applying duplicate resources. Can we create a CRP to select duplicate ns to make sure it's working as expected?
Hi Zhiying! Yeah, there might be a misunderstanding here; the bug wasn't about duplicated resources specifically, it's that any pre-processing failure would trigger the work applier to stop processing remaining manifests after parallelism is removed. |
Description of your changes
This PR fixes the bug where the work applier would stop processing manifests if one of them fails the pre-processing stage.
Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer