feat: block member label modification through DP#1109
Closed
audrastump wants to merge 6 commits intoAzure:mainfrom
Closed
feat: block member label modification through DP#1109audrastump wants to merge 6 commits intoAzure:mainfrom
audrastump wants to merge 6 commits intoAzure:mainfrom
Conversation
audrastump
changed the title
jim-minter
changed the title
jim-minter
reviewed
Apr 9, 2025
| resourceValidator: fleetResourceValidator{ | ||
| decoder: decoder, | ||
| }, | ||
| wantResponse: admission.Denied(fmt.Sprintf(validation.DeniedModifyFleetLabels)), |
Member
There was a problem hiding this comment.
Suggested change
| wantResponse: admission.Denied(fmt.Sprintf(validation.DeniedModifyFleetLabels)), | |
| wantResponse: admission.Denied(validation.DeniedModifyFleetLabels), |
jim-minter
approved these changes
Apr 9, 2025
Contributor
|
Hi @audrastump could you take a look at the e2e tests and be sure the failures are not related to your change? Just from a glance it looks like 1 might be affected. |
Contributor
|
Hi Audra! I am closing this PR as Fleet has been accepted as a CNCF project and per our agreement with CNCF we will be moving to a CNCF-hosted neutral repo for future development; please consider moving (re-creating) this PR in the new repo, once the sync PR is merged. If there's any question/concern, please let me know. Thanks 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Blocking users from modifying member cluster labels directly through the dataplane unless they are the RP client.
Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Unit tests
Special notes for your reviewer