chore: Last backport of March#1281
Merged
britaniar merged 4 commits intoAzure:mainfrom Mar 30, 2026
Merged
Conversation
* update the placement v1 with PR and CPRS
Signed-off-by: Ryan Zhang <yangzhangrice@hotmail.com>
* update the placement v1 with PR and CPRS
Signed-off-by: Ryan Zhang <yangzhangrice@hotmail.com>
* fix the test now that we aded per cluster resource index
Signed-off-by: Ryan Zhang <yangzhangrice@hotmail.com>
* fix: address code review issues in placement v1 API types
- Add CEL immutability validations to CRP Spec (matching v1beta1):
policy cannot be removed once set, statusReportingScope immutable,
placementType immutable, and namespace selector requirement when
StatusReportingScope=NamespaceAccessible
- Fix contradictory +kubebuilder:validation:Required + omitempty on
ClusterResourcePlacementStatus fields (PlacementStatus, LastUpdatedTime)
- Add missing +kubebuilder:object:root=true to ResourcePlacementList
and ClusterResourcePlacementStatusList
Signed-off-by: Ryan Zhang <yangzhangrice@hotmail.com>
* fix: pin goimports to v0.42.0 and make envelope work de-duplication resilient
Two CI fixes:
1. Makefile: pin GOIMPORTS_VER from 'latest' to v0.42.0.
golang.org/x/tools v0.43.0 (latest) now requires Go >= 1.25.0, but
CI runs Go 1.24.13, causing the unit-and-integration-tests job to
fail at setup with:
go: golang.org/x/tools/cmd/goimports@latest: requires go >= 1.25.0
2. pkg/controllers/workgenerator/envelope.go: when multiple work objects
are found for the same envelope (possible transiently if the same CRP
name is reused quickly after deletion), self-heal by deleting all but
the most recently created work and proceeding, instead of returning an
UnexpectedBehaviorError that causes WorkSynchronized=False on the
binding. The previous hard-fail path caused e2e test flakiness in the
'mixed availability statefulset' case where cluster-1's workgenerator
would encounter leftover work objects from the prior test context.
Signed-off-by: Ryan Zhang <yangzhangrice@hotmail.com>
* feat: address PR Azure#484 review feedback
Remove deprecated ConfigMapEnvelopeType from v1 API, drop duplicate ResourcePlacement* condition types in favor of shorter variants, add CEL validation for placement type immutability on Policy field, and fix envelope duplicate work test to match self-healing behavior.
Signed-off-by: Yetkin Timocin <ytimocin@microsoft.com>
* Addressing feedback and adding some missing properties
Signed-off-by: Yetkin Timocin <ytimocin@microsoft.com>
* Address further feedback
Signed-off-by: Yetkin Timocin <ytimocin@microsoft.com>
---------
Signed-off-by: Ryan Zhang <yangzhangrice@hotmail.com>
Signed-off-by: Yetkin Timocin <ytimocin@microsoft.com>
Co-authored-by: Ryan Zhang <yangzhangrice@hotmail.com>
Co-authored-by: ryanzhang-oss <ryanzhang-oss@users.noreply.github.com>
Signed-off-by: Yetkin Timocin <ytimocin@microsoft.com>
ytimocin
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer