Skip to content

feat: add mutating webhook to label managed deploys created by aksService#1298

Merged
jwtty merged 1 commit intoAzure:mainfrom
jwtty:mutating-webhook
Apr 30, 2026
Merged

feat: add mutating webhook to label managed deploys created by aksService#1298
jwtty merged 1 commit intoAzure:mainfrom
jwtty:mutating-webhook

Conversation

@jwtty
Copy link
Copy Markdown
Contributor

@jwtty jwtty commented Apr 23, 2026

Description of your changes

  1. Add a mutating webhook to add reconcile label on deploy and deploy pod template created by user aksService on hub cluster.
  2. Do not block pod/rs creation/update with this label.
  3. Add a validating webhook to prevent regular user from being able to add the label to their template.
  4. Disable enableWorkload flag in e2e.
    Fixes #

I have:

  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

Special notes for your reviewer

@jwtty jwtty force-pushed the mutating-webhook branch 2 times, most recently from 9508dce to 909862a Compare April 23, 2026 21:02
Comment thread pkg/webhook/deployment/mutating_webhook.go
Comment thread pkg/webhook/deployment/validating_webhook.go
Comment thread pkg/webhook/deployment/deployment_validating_webhook.go Outdated
Comment thread pkg/webhook/deployment/deployment_validating_webhook.go Outdated
Comment thread pkg/webhook/deployment/mutating_webhook_test.go
Comment thread pkg/webhook/pod/pod_validating_webhook.go
Comment thread test/e2e/fleet_guard_rail_test.go
Comment thread pkg/webhook/deployment/mutating_webhook.go
Copy link
Copy Markdown
Contributor

@michaelawyu michaelawyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ;)

@jwtty jwtty force-pushed the mutating-webhook branch from 9c5672f to 86e69d1 Compare April 29, 2026 21:36
@jwtty jwtty force-pushed the mutating-webhook branch from 86e69d1 to 03fc1d3 Compare April 30, 2026 18:03
@jwtty jwtty merged commit efda897 into Azure:main Apr 30, 2026
19 of 29 checks passed
@jwtty jwtty deleted the mutating-webhook branch April 30, 2026 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants