This repository was archived by the owner on Oct 12, 2023. It is now read-only.
Build libuv using the same CMake machinery as other dependencies#568
Open
damonbarry wants to merge 5 commits into
Open
Build libuv using the same CMake machinery as other dependencies#568damonbarry wants to merge 5 commits into
damonbarry wants to merge 5 commits into
Conversation
Member
Author
|
I've updated the build for Windows and Linux too. I've confirmed that all platforms build successfully with their build scripts (build.sh or build.cmd), and that |
This was referenced Apr 10, 2018
Open
darobs
approved these changes
Apr 13, 2018
Member
Author
|
I pushed a few more commits:
NOTE on macOS I had to upgrade XCode developer command line tools in order to get past a weird CMake error. I did |
darobs
reviewed
Apr 16, 2018
| The sample code and dependancies gets build by running: | ||
| ``` | ||
| tools\build.sh --enable-dotnet-core-binding --disable-native-remote-modules | ||
| tools\build.sh --enable-dotnet-core-binding |
Contributor
There was a problem hiding this comment.
Drop the --enable-dotnet-core-binding here?
Member
Author
There was a problem hiding this comment.
This sample (dotnet_core_dynamic_add_module) is specifically about the .NET Core binding, so I think it's correct as-is.
darobs
approved these changes
Apr 16, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes are incomplete--they work on macOS but I haven't added support yet for Linux or Windows (unfortunately the build instructions for libuv are a little different on each platform). But a related conversation came up in #280, so I'll post this now for people to look at.