Commit 111995d
authored
[BMC] Align is_bmc_supported check for the new infra (#385)
<!--
Please make sure you've read and understood our contributing guidelines:
https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md
CODE_OF_CONDUCT.md LICENSE README.md SECURITY.md SUPPORT.md azure-pipelines failure_prs.log scripts skip_prs.log Make sure all your commits include a signature generated with `git commit -s` **
If this is a bug fix, make sure your description includes "closes #xxxx",
"fixes #xxxx" or "resolves #xxxx" so that GitHub automatically closes the related
issue when the PR is merged.
If you are adding/modifying/removing any command or utility script, please also
make sure to add/modify/remove any unit tests from the tests
directory as appropriate.
If you are modifying or removing an existing 'show', 'config' or 'sonic-clear'
subcommand, or you are adding a new subcommand, please make sure you also
update the Command Line Reference Guide (doc/Command-Reference.md) to reflect
your changes.
Please provide the following information:
-->
#### What I did
The BMC support check in `generate_dump` was aligned with the new infrastructure flow
(sonic-net/sonic-buildimage#26544).
Instead of checking for platform-local `bmc.json` assumptions, the logic now validates host-side role and runtime BMC data from the canonical source used by the system.
#### How I did it
- Updated `generate_dump` BMC detection to use `device_info.is_switch_host()` together with
`device_info.get_bmc_data()`.
- Removed reliance on legacy platform-folder `bmc.json` existence behavior for this path.
- Kept the `generate_dump` flow behavior intact while aligning detection to runtime
`/etc/sonic/bmc.json`-based APIs.
#### How to verify it
- Run `show techsupport` (or `generate_dump`) on:
- a switch-host platform with valid BMC data and verify BMC-related flow executes.
- a non-switch-host / missing-BMC-data platform and verify BMC path is skipped.
Signed-off-by: Sonic Build Admin <sonicbld@microsoft.com>
#### Previous command output (if the output of a command-line utility has changed)
#### New command output (if the output of a command-line utility has changed)1 parent 69c164d commit 111995d
1 file changed
Lines changed: 1 addition & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2271 | 2271 | | |
2272 | 2272 | | |
2273 | 2273 | | |
2274 | | - | |
2275 | | - | |
2276 | | - | |
2277 | | - | |
2278 | | - | |
2279 | | - | |
2280 | | - | |
| 2274 | + | |
2281 | 2275 | | |
2282 | 2276 | | |
2283 | 2277 | | |
| |||
0 commit comments