Skip checking offload flags for static routes/sids in route check and add check_sids (#187)

<!--
 Please make sure you've read and understood our contributing guidelines:
 https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md

 failure_prs.log skip_prs.log Make sure all your commits include a signature generated with `git commit -s` **

 If this is a bug fix, make sure your description includes "closes #xxxx",
 "fixes #xxxx" or "resolves #xxxx" so that GitHub automatically closes the related
 issue when the PR is merged.

 If you are adding/modifying/removing any command or utility script, please also
 make sure to add/modify/remove any unit tests from the tests
 directory as appropriate.

 If you are modifying or removing an existing 'show', 'config' or 'sonic-clear'
 subcommand, or you are adding a new subcommand, please make sure you also
 update the Command Line Reference Guide (doc/Command-Reference.md) to reflect
 your changes.

 Please provide the following information:
-->

#### What I did

1. Skip checking offload flags for static routes and static SIDs in FRR in check_frr_pending_routes.
2. Add check_sids to check consistency between MY_SID tables of ASIC_DB and APPL_DB

#### How I did it

#### How to verify it

Run on a device supporting SRv6

#### Previous command output (if the output of a command-line utility has changed)

#### New command output (if the output of a command-line utility has changed)

Author: mssonicbld

scripts/route_check.py

@@ -328,6 +328,52 @@ def get_asicdb_routes(namespace):
     return (selector, subs, sorted(rt))
 
 
+def get_appdb_sids(namespace):
+    """
+    helper to read SIDs table from APPL-DB.
+    :return list of sorted SIDs with prefix ensured
+    """
+    db = swsscommon.DBConnector(APPL_DB_NAME, REDIS_TIMEOUT_MSECS, True, namespace)
+    print_message(syslog.LOG_DEBUG, "APPL DB connected for sids")
+    tbl = swsscommon.Table(db, 'SRV6_MY_SID_TABLE')
+    keys = tbl.getKeys()
+
+    sids = sorted(keys)
+    print_message(syslog.LOG_DEBUG, json.dumps({"APPL_MY_SID_TABLE": sids}, indent=4))
+    return sids
+
+
+def get_asicdb_sids(namespace):
+    """
+    helper to read SIDs table from APPL-DB.
+    :return list of sorted SIDs with prefix ensured
+    """
+    db = swsscommon.DBConnector(ASIC_DB_NAME, REDIS_TIMEOUT_MSECS, True, namespace)
+    print_message(syslog.LOG_DEBUG, "ASIC DB connected for sids")
+    tbl = swsscommon.Table(db, ASIC_TABLE_NAME)
+    keys = tbl.getKeys()
+
+    sids = []
+    for k in keys:
+        content = k.split(":", 1)
+        if content[0] != 'SAI_OBJECT_TYPE_MY_SID_ENTRY':
+            continue
+        sid_info = json.loads(content[1])
+        sid_entry = ":".join([
+            sid_info.get("locator_block_len", "0"),
+            sid_info.get("locator_node_len", "0"),
+            sid_info.get("function_len", "0"),
+            sid_info.get("args_len", "0"),
+            sid_info.get("sid")
+        ])
+
+        sids.append(sid_entry)
+
+    sids = sorted(sids)
+    print_message(syslog.LOG_DEBUG, json.dumps({"ASIC_MY_SID_TABLE": sids}, indent=4))
+    return sids
+
+
 def is_suppress_fib_pending_enabled(namespace):
     """
     Returns True if FIB suppression is enabled, False otherwise
@@ -560,7 +606,7 @@ def check_frr_pending_routes(namespace):
 
         for _, entries in frr_routes.items():
             for entry in entries:
-                if entry['protocol'] in ('connected', 'kernel'):
+                if entry['protocol'] in ('connected', 'kernel', 'static'):
                     continue
 
                 # TODO: Also handle VRF routes. Currently this script does not check for VRF routes so it would be incorrect for us
@@ -804,6 +850,74 @@ def check_routes(namespace):
         print_message(syslog.LOG_INFO, "All good!")
         return 0, None
 
+
+def check_sids_for_namespace(namespace):
+    """
+    Process a Single Namespace for SIDs consistency check:
+    Read APPL-DB & ASIC-DB, the relevant tables for SID checking.
+    Checkout SIDs in ASIC-DB to match APPL-DB. Compared to check_routes,
+    this function does not wait for subscriber updates, as SIDs are not
+    expected to change frequently.
+
+    :return (0, None) on sucess, else (-1, results) where results holds
+    the unjustifiable entries.
+    """
+
+    results = {}
+    sid_appl_miss = []
+    sid_asic_miss = []
+
+    sids_asic = get_asicdb_sids(namespace)
+
+    sids_appl = get_appdb_sids(namespace)
+
+    # Diff APPL-DB SIDs & ASIC-DB SIDs
+    sid_appl_miss, sid_asic_miss = diff_sorted_lists(sids_appl, sids_asic)
+
+    if sid_appl_miss:
+        results["missed_APPL_MY_SID_TABLE_entries"] = sid_appl_miss
+
+    if sid_asic_miss:
+        results["missed_ASIC_MY_SID_TABLE_entries"] = sid_asic_miss
+
+    return results
+
+
+def check_sids(namespace):
+    """
+    Main function to parallelize SID checks across all namespaces.
+    """
+    namespace_list = []
+    if namespace is not multi_asic.DEFAULT_NAMESPACE and namespace in multi_asic.get_namespace_list():
+        namespace_list.append(namespace)
+    else:
+        namespace_list = multi_asic.get_namespace_list()
+        print_message(syslog.LOG_INFO, "Checking SIDs for namespaces: ", namespace_list)
+
+    results = {}
+
+    # Use ThreadPoolExecutor to parallelize the check for each namespace
+    with concurrent.futures.ThreadPoolExecutor() as executor:
+        futures = {executor.submit(check_sids_for_namespace, ns): ns for ns in namespace_list}
+
+        for future in concurrent.futures.as_completed(futures):
+            ns = futures[future]
+            try:
+                result = future.result()
+                if result:
+                    results[ns] = result
+            except Exception as e:
+                print_message(syslog.LOG_ERR, "Error processing namespace {}: {}".format(ns, e))
+                return -1, results
+
+    if results:
+        print_message(syslog.LOG_WARNING, "SIDs Check Failure results: {",  json.dumps(results, indent=4), "}")
+        return -1, results
+    else:
+        print_message(syslog.LOG_INFO, "All good!")
+        return 0, None
+
+
 def main():
     """
     main entry point, which mainly parses the args and call check_routes
@@ -849,9 +963,22 @@ def main():
 
     while True:
         signal.alarm(TIMEOUT_SECONDS)
-        ret, res= check_routes(namespace)
-        print_message(syslog.LOG_DEBUG, "ret={}, res={}".format(ret, res))
+        ret1, res1 = check_routes(namespace)
+        print_message(syslog.LOG_DEBUG, "check_routes: ret={}, res={}".format(ret1, res1))
+        ret2, res2 = check_sids(namespace)
+        print_message(syslog.LOG_DEBUG, "check_sids: ret={}, res={}".format(ret2, res2))
         signal.alarm(0)
+        if ret1 < 0 or ret2 < 0:
+            ret = -1
+        else:
+            ret = 0
+
+        if res1 is not None or res2 is not None:
+            res = dict()
+            res.update(res1 if res1 else {})
+            res.update(res2 if res2 else {})
+        else:
+            res = None
 
         if interval:
             time.sleep(interval)