Skip to content

Commit f24cc0c

Browse files
authored
[chassis][show_tech]Fix show queue counters to only run on host (#173)
<!-- Please make sure you've read and understood our contributing guidelines: https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md failure_prs.log skip_prs.log Make sure all your commits include a signature generated with `git commit -s` ** If this is a bug fix, make sure your description includes "closes #xxxx", "fixes #xxxx" or "resolves #xxxx" so that GitHub automatically closes the related issue when the PR is merged. If you are adding/modifying/removing any command or utility script, please also make sure to add/modify/remove any unit tests from the tests directory as appropriate. If you are modifying or removing an existing 'show', 'config' or 'sonic-clear' subcommand, or you are adding a new subcommand, please make sure you also update the Command Line Reference Guide (doc/Command-Reference.md) to reflect your changes. Please provide the following information: --> #### What I did `show queue counters` is supported and runs on host instance, even for mult-asic platforms. We don't have to run `show queue counters` for each asic namespace. This fixes sonic-net/sonic-buildimage#22394 #### How I did it Modifiy generate_dump to call `save_cmd` instead of `save_cmd_all_ns` for `show queue counters` #### How to verify it Run `show techsupport` on multi-asic platform. Verfiy that the `queue.counters` files show correct information. #### Which release branch to backport (provide reason below if selected) - [ ] 202305 - [x] 202405 #### Previous command output (if the output of a command-line utility has changed) #### New command output (if the output of a command-line utility has changed)
1 parent 2c35fdf commit f24cc0c

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

scripts/generate_dump

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2007,7 +2007,7 @@ save_counter_snapshot() {
20072007
save_cmd "echo $counter_t" "date.counter_$idx"
20082008
save_cmd "show interface counters" "interface.counters_$idx"
20092009
if ! $IS_SUPERVISOR; then
2010-
save_cmd_all_ns "show queue counters" "queue.counters_$idx"
2010+
save_cmd "show queue counters" "queue.counters_$idx"
20112011
fi
20122012
save_redis "COUNTERS_DB" "COUNTERS_DB_$idx"
20132013

0 commit comments

Comments
 (0)