[action] [PR:4343] Change sensorshow conn to use TCP socket#292
Merged
Conversation
<!--
Please make sure you've read and understood our contributing guidelines:
https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md
** Make sure all your commits include a signature generated with `git commit -s` **
If this is a bug fix, make sure your description includes "closes #xxxx",
"fixes #xxxx" or "resolves #xxxx" so that GitHub automatically closes the related
issue when the PR is merged.
If you are adding/modifying/removing any command or utility script, please also
make sure to add/modify/remove any unit tests from the tests
directory as appropriate.
If you are modifying or removing an existing 'show', 'config' or 'sonic-clear'
subcommand, or you are adding a new subcommand, please make sure you also
update the Command Line Reference Guide (doc/Command-Reference.md) to reflect
your changes.
Please provide the following information:
-->
#### What I did
Change the DB connection in `scripts/sensorshow` to use TCP socket.
#### How I did it
#### How to verify it
Run the commands that invoke `sensorshow` (e.g. `show platform voltage`) without `write` permission to see if it's returning the correct output instead of the `RuntimeError: Unable to connect to redis (unix-socket) - Permission denied(1): Cannot assign requested address` error
#### Previous command output (if the output of a command-line utility has changed)
`RuntimeError: Unable to connect to redis (unix-socket) - Permission denied(1): Cannot assign requested address`
#### New command output (if the output of a command-line utility has changed)
```
user@SONiC-DUT-sup00:~$ show platform voltage
Sensor Voltage High TH Low TH Crit High TH Crit Low TH Warning Timestamp
--------------- --------- --------- -------- -------------- ------------- --------- -----------------
FC0_HOTSWAP_VIN 55275 mV 58860 49140 59400 48600 False 20260310 03:04:31
FC2_HOTSWAP_VIN 55350 mV 58860 49140 59400 48600 False 20260310 03:04:31
FC4_HOTSWAP_VIN 55300 mV 58860 49140 59400 48600 False 20260310 03:04:31
FC5_HOTSWAP_VIN 55275 mV 58860 49140 59400 48600 False 20260310 03:04:31
FC6_HOTSWAP_VIN 55250 mV 58860 49140 59400 48600 False 20260310 03:04:31
MB_VP54P0V 55350 mV 59343 48806 59913 48298 False 20260310 03:04:31
```
Signed-off-by: Sonic Build Admin <sonicbld@microsoft.com>
Collaborator
Author
|
Original PR: sonic-net/sonic-utilities#4343 |
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Change the DB connection in
scripts/sensorshowto use TCP socket.How I did it
How to verify it
Run the commands that invoke
sensorshow(e.g.show platform voltage) withoutwritepermission to see if it's returning the correct output instead of theRuntimeError: Unable to connect to redis (unix-socket) - Permission denied(1): Cannot assign requested addresserrorPrevious command output (if the output of a command-line utility has changed)
RuntimeError: Unable to connect to redis (unix-socket) - Permission denied(1): Cannot assign requested addressNew command output (if the output of a command-line utility has changed)
Signed-off-by: Sonic Build Admin sonicbld@microsoft.com