Skip to content

[action] [PR:4531] [console] improve picocom launch efficiency#376

Merged
mssonicbld merged 1 commit into
Azure:202603from
mssonicbld:cherry/msft-202603/4531
Jun 24, 2026
Merged

[action] [PR:4531] [console] improve picocom launch efficiency#376
mssonicbld merged 1 commit into
Azure:202603from
mssonicbld:cherry/msft-202603/4531

Conversation

@mssonicbld

Copy link
Copy Markdown
Collaborator

replace pexpect calls with direct function call and exec while preserving the original logic

What I did

streamlined the picocom launch process

How I did it

replaced the first pexpect call with a direct function call
wrapped the picocom launch in a bash script
replaced the second pexpect call with execvp

How to verify it

first, launch console app just like before
then, use ps -ef to make sure "connect line" is no longer a standalone process

Previous command output (if the output of a command-line utility has changed)

connect line X or just reverse ssh

Signed-off-by: Sonic Build Admin sonicbld@microsoft.com

replace pexpect calls with direct function call and exec while preserving the original logic

<!--
    Please make sure you've read and understood our contributing guidelines:
    https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md

    ** Make sure all your commits include a signature generated with `git commit -s` **

    If this is a bug fix, make sure your description includes "closes #xxxx",
    "fixes #xxxx" or "resolves #xxxx" so that GitHub automatically closes the related
    issue when the PR is merged.

    If you are adding/modifying/removing any command or utility script, please also
    make sure to add/modify/remove any unit tests from the tests
    directory as appropriate.

    If you are modifying or removing an existing 'show', 'config' or 'sonic-clear'
    subcommand, or you are adding a new subcommand, please make sure you also
    update the Command Line Reference Guide (doc/Command-Reference.md) to reflect
    your changes.

    Please provide the following information:
-->

#### What I did
streamlined the picocom launch process

#### How I did it
replaced the first pexpect call with a direct function call
wrapped the picocom launch in a bash script
replaced the second pexpect call with execvp

#### How to verify it
first, launch console app just like before
then, use ps -ef to make sure "connect line" is no longer a standalone process

#### Previous command output (if the output of a command-line utility has changed)
connect line X or just reverse ssh

Signed-off-by: Sonic Build Admin <sonicbld@microsoft.com>
@mssonicbld

Copy link
Copy Markdown
Collaborator Author

Original PR: sonic-net/sonic-utilities#4531

@mssonicbld

Copy link
Copy Markdown
Collaborator Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@mssonicbld mssonicbld merged commit 6f9a736 into Azure:202603 Jun 24, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant