Skip to content

[action] [PR:4625] [Port Mirror][CLI] Align ERSPAN sample_rate range with YANG model#381

Merged
mssonicbld merged 1 commit into
Azure:202607from
mssonicbld:cherry/msft-202607/4625
Jun 29, 2026
Merged

[action] [PR:4625] [Port Mirror][CLI] Align ERSPAN sample_rate range with YANG model#381
mssonicbld merged 1 commit into
Azure:202607from
mssonicbld:cherry/msft-202607/4625

Conversation

@mssonicbld

Copy link
Copy Markdown
Collaborator

What I did

Aligned the ERSPAN mirror session sample_rate validation range with the YANG model (sonic-buildimage #26756), which defines it as uint32 2..max.

How I did it

  • config/main.py: changed from SAMPLE_RATE_MIN 256 to 2, changed SAMPLE_RATE_MAX 8388608 to 0xFFFFFFFF (uint32 max).
  • tests/config_mirror_session_test.py: updated assertions and reworked the boundary test.
  • doc/Command-Reference.md: updated the valid range.

How to verify it

pytest tests/config_mirror_session_test.py

Signed-off-by: Sonic Build Admin sonicbld@microsoft.com

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

<!--
    Please make sure you've read and understood our contributing guidelines:
    https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md

    ** Make sure all your commits include a signature generated with `git commit -s` **

    If this is a bug fix, make sure your description includes "closes #xxxx",
    "fixes #xxxx" or "resolves #xxxx" so that GitHub automatically closes the related
    issue when the PR is merged.

    If you are adding/modifying/removing any command or utility script, please also
    make sure to add/modify/remove any unit tests from the tests
    directory as appropriate.

    If you are modifying or removing an existing 'show', 'config' or 'sonic-clear'
    subcommand, or you are adding a new subcommand, please make sure you also
    update the Command Line Reference Guide (doc/Command-Reference.md) to reflect
    your changes.

    Please provide the following information:
-->

#### What I did
Aligned the ERSPAN mirror session `sample_rate` validation range with the YANG model ([sonic-buildimage #26756](sonic-net/sonic-buildimage#26756)), which defines it as uint32 `2..max`.

#### How I did it
 - `config/main.py`: changed from `SAMPLE_RATE_MIN` 256 to 2, changed `SAMPLE_RATE_MAX` 8388608 to `0xFFFFFFFF` (uint32 max).
 - `tests/config_mirror_session_test.py`: updated assertions and reworked the boundary test.
 - `doc/Command-Reference.md`: updated the valid range.

#### How to verify it
 pytest tests/config_mirror_session_test.py

Signed-off-by: Sonic Build Admin <sonicbld@microsoft.com>

#### Previous command output (if the output of a command-line utility has changed)

#### New command output (if the output of a command-line utility has changed)
@mssonicbld

Copy link
Copy Markdown
Collaborator Author

Original PR: sonic-net/sonic-utilities#4625

@mssonicbld

Copy link
Copy Markdown
Collaborator Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@mssonicbld mssonicbld merged commit 647b47b into Azure:202607 Jun 29, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant